Skip to content

Conversation

@MoritzWeber0
Copy link
Member

@MoritzWeber0 MoritzWeber0 commented Jun 20, 2025

Bootstrap was a good library to get started faster, but we've mostly used custom styling and most of the bootstrap functionality wasn't used.

Removing bootstrap provides a few advantages:

  • We gain full control over the styles
  • Better adoption to CSS BEM (we can choose our own class names)
  • Reduced bundle size
  • Better DevTools support. Chrome and Firefox have some neat development tools around grid layout. The devtools didn't work with the bootstrap grid layout.
  • Less chance of breaking changes. Bootstrap is under active development and can introduce breaking changes. CSS itself is considered as rather stable.

As proposed in #192 (comment), the removal of bootstrap as separate PR. Resolves #74.

Beside some minor changes to margins and sizes, the most significant visual change is the style of tables, which I changed as part of this PR.

@netlify
Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit deca257
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/68690a18095c92000880ea48
😎 Deploy Preview https://deploy-preview-208--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MoritzWeber0 MoritzWeber0 added the technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc. label Jun 21, 2025
Base automatically changed from feat/new-design to main June 22, 2025 20:21
@MoritzWeber0 MoritzWeber0 force-pushed the refactor/replace-bootstrap branch from 29b7b8e to 84f90ef Compare June 24, 2025 21:09
@MoritzWeber0 MoritzWeber0 changed the title refactor: Replace bootstrap grid with CSS grid refactor: Replace boostrap with custom CSS Jun 24, 2025
@MoritzWeber0 MoritzWeber0 force-pushed the refactor/replace-bootstrap branch 5 times, most recently from bfa1fb5 to 84ffe66 Compare June 29, 2025 16:14
@MoritzWeber0 MoritzWeber0 marked this pull request as ready for review June 29, 2025 16:14
@MoritzWeber0 MoritzWeber0 force-pushed the refactor/replace-bootstrap branch 2 times, most recently from 5a5987b to a47c580 Compare July 5, 2025 10:22
@MoritzWeber0 MoritzWeber0 marked this pull request as draft July 5, 2025 10:23
@MoritzWeber0 MoritzWeber0 force-pushed the refactor/replace-bootstrap branch from a47c580 to a30a265 Compare July 5, 2025 10:27
@MoritzWeber0 MoritzWeber0 marked this pull request as ready for review July 5, 2025 10:30
@lenderom lenderom removed their request for review July 5, 2025 11:17
@therobrob therobrob merged commit 200436e into main Jul 5, 2025
7 checks passed
@therobrob therobrob deleted the refactor/replace-bootstrap branch July 5, 2025 11:20
@therobrob
Copy link
Member

Thanks @MoritzWeber0 for your effort removing bootstrap! <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Check necessity of bootstrap

3 participants