fix: Avoid layout shifts by pre-allocating space for pictures #248
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
So far, images don't set a fixed height for images. This leads to layout shifts while loading since CSS can only recognize the size of the image when loaded. By setting the aspact ratio on the img-element, the browser can already pre-allocate the necessary space. When the image is loaded, the layout no longer shifts.
MoritzWeber0
force-pushed
the
fix/seo-image-ratio
branch
from
d092530 to
904e37f
Compare
Member
|
Hi @MoritzWeber0, i've noticed the error in footer.hmtl already. There were some email-notifications about it and i already fixed it. There is no need to fix this in this PR. :) |
therobrob
approved these changes
Jul 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So far, images don't set a fixed height for images. This leads to layout shifts since CSS can only recognize the size of the image when loaded.
By setting the aspect ratio on the
imgelement, the browser can already pre-allocate the necessary space. When the image is loaded, the layout no longer shifts.Layout shifts are one of the main complaints in the Google Lighthouse report:
For more information, check the Google recommendations for image spacing: https://web.dev/articles/optimize-cls?utm_source=lighthouse&utm_medium=devtools#images-without-dimensions
Resolves #73