Skip to content

fix: Avoid layout shifts by pre-allocating space for pictures #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
therobrob merged 4 commits into from
Jul 20, 2025
Merged

fix: Avoid layout shifts by pre-allocating space for pictures #248

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
904e37f
fix: Avoid layout shifts by pre-allocating space for pictures
MoritzWeber0 Jul 19, 2025
0d4df46
Merge branch 'main' into fix/seo-image-ratio
therobrob Jul 20, 2025
197a754
fix: Pre-commit hooks
MoritzWeber0 Jul 20, 2025
f1177f5
Merge branch 'main' into fix/seo-image-ratio
therobrob Jul 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion assets/sass/teaser.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@
}

.m-teaser__image img {
aspect-ratio: 16/9;
border-radius: var(--border-radius-l) var(--border-radius-l) 0 0;
object-fit: cover;
height: 100%;
Expand Down
61 changes: 36 additions & 25 deletions layouts/partials/image.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,30 +13,41 @@
{{- $name := $image.RelPermalink | strings.TrimSuffix (printf ".%s" $image.MediaType.SubType) -}}
{{- $extension := $image.MediaType.SubType -}}

<picture>
{{- $widths := slice -}}
{{- if gt $image.Width 500 -}}
{{- $widths = $widths | append 500 -}}
{{- end -}}
{{- if gt $image.Width 800 -}}
{{- $widths = $widths | append 800 -}}
{{- end -}}
{{- if gt $image.Width 1200 -}}
{{- $widths = $widths | append 1200 -}}
{{- end -}}
{{- if gt $image.Width 1500 -}}
{{- $widths = $widths | append 1500 -}}
{{- end -}}
{{- if gt $image.Width 2200 -}}
{{- $widths = $widths | append 2200 -}}
{{- end -}}
{{- $widths := slice -}}
{{- if gt $image.Width 500 -}}
{{- $widths = $widths | append 500 -}}
{{- end -}}
{{- if gt $image.Width 800 -}}
{{- $widths = $widths | append 800 -}}
{{- end -}}
{{- if gt $image.Width 1200 -}}
{{- $widths = $widths | append 1200 -}}
{{- end -}}
{{- if gt $image.Width 1500 -}}
{{- $widths = $widths | append 1500 -}}
{{- end -}}
{{- if gt $image.Width 2200 -}}
{{- $widths = $widths | append 2200 -}}
{{- end -}}

{{- $srcset := slice -}}
{{- range $i, $width := $widths -}}
{{- with $image.Resize (printf "%dx" $width) | resources.Copy (print $name "_" $width "." $extension) -}}
{{- $srcset = $srcset | append (printf "%s %dw" .RelPermalink $width) -}}
{{- end -}}
{{- $srcset := slice -}}
{{- range $i, $width := $widths -}}
{{- with $image.Resize (printf "%dx" $width) | resources.Copy (print $name "_" $width "." $extension) -}}
{{- $srcset = $srcset | append (printf "%s %dw" .RelPermalink $width) -}}
{{- end -}}
{{- $srcset = $srcset | append (printf "%s %dw" $image.RelPermalink $image.Width) -}}
{{- printf "<img src=\"%s\" alt=\"\" loading=\"%s\" srcset=\"%s\" sizes=\"(max-width: 576px) calc(100vw - 3.2rem), (max-width: 768px) 540px, (max-width: 992px) 720px, (max-width: 1200px) 960px, (max-width: 1400px) 1140px, 1320px\">" $image.RelPermalink $loading (delimit $srcset ", ") | safeHTML -}}
</picture>
{{- end -}}
{{- $srcset = $srcset | append (printf "%s %dw" $image.RelPermalink $image.Width) -}}

{{- $styles := "" -}}
{{- if and $image.Width -}}
{{- $styles = printf "aspect-ratio: %d / %d" $image.Width $image.Height -}}
{{- end -}}

<img
src="{{ $image.RelPermalink }}"
alt=""
loading="{{ $loading }}"
srcset="{{ delimit $srcset ", " }}"
sizes="(max-width: 576px) calc(100vw - 3.2rem), (max-width: 768px) 540px, (max-width: 992px) 720px, (max-width: 1200px) 960px, (max-width: 1400px) 1140px, 1320px"
style="{{ $styles | safeCSS }}"
>
Loading