-
-
Notifications
You must be signed in to change notification settings - Fork 17
fix: adjustments to german grammar #452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for fipguide ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Hi there! 👋 Thank you for your contribution to the FIP Guide! 🚀 Checklist before merging:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request introduces a German style guide and applies its typography and terminology standards across multiple content files. The changes focus on consistent formatting of currency values, proper terminology (replacing "Rabatt" with "Ermäßigung"), and correcting a spelling error.
- Adds a comprehensive German style guide covering typography, spacing, gender-neutral language, and punctuation
- Standardizes currency formatting with spaces between numbers and currency symbols (e.g.,
10€→10 €) - Replaces "Rabatt" with "Ermäßigung" for consistency in FIP discount terminology
- Corrects spelling error: "Freifahrtsschein" → "Freifahrtschein"
Reviewed Changes
Copilot reviewed 9 out of 13 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| styleguide_de.md | New German style guide document defining typography, spacing, and language standards |
| content/operator/sncf/index.de.md | Corrects spelling of "Freifahrtschein" |
| content/operator/oebb/index.de.md | Standardizes currency spacing and replaces "Rabatt" with "Ermäßigung" |
| content/operator/gysev/index.de.md | Replaces "Rabatt" with "Ermäßigung" |
| content/operator/eurostar/index.de.md | Standardizes currency spacing and replaces "Rabatt" with "Ermäßigung" |
| content/news/5/index.de.md | Standardizes currency spacing throughout |
| content/country/united-kingdom/index.de.md | Replaces "Rabatt" with "Ermäßigung" and adjusts grammatical agreement |
| content/country/switzerland/index.de.md | Standardizes currency spacing |
| content/country/italy/index.de.md | Standardizes currency spacing |
| content/country/france/index.de.md | Replaces "Rabatt" with "Ermäßigung" (appears twice) |
| content/country/austria/index.de.md | Standardizes currency spacing |
| content/booking/sncf-ticket-office/index.de.md | Replaces "Rabatt" with "Ermäßigung" |
| content/booking/sncf-phone/index.de.md | Replaces "Rabatt" with "Ermäßigung" (multiple instances) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi Toni, thanks a lot for the styleguide – i've done some content improvements with this :) |
MoritzWeber0
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The styleguide looks good in general. There will be some additional work to update the content to the new style. But this can be done afterwards in separate PRs.
The recommendations are summarized in the issue #356. I have also made adjustments to the german versions.