Skip to content

Conversation

@toniarndt
Copy link
Contributor

The recommendations are summarized in the issue #356. I have also made adjustments to the german versions.

Copilot AI review requested due to automatic review settings October 31, 2025 19:04
@toniarndt toniarndt linked an issue Oct 31, 2025 that may be closed by this pull request
@netlify
Copy link

netlify bot commented Oct 31, 2025

Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 124910a
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/691a4689a4f03400081d8068
😎 Deploy Preview https://deploy-preview-452--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

Hi there! 👋

Thank you for your contribution to the FIP Guide! 🚀
We appreciate your effort in making rail staff travel information more accessible. 🚄

Checklist before merging:

  • Added a description to the Pull Request
  • Checked the License of new pictures (non-commercial use without attribution)
  • Modified content in English
  • Modified content in German
  • Modified content in French

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces a German style guide and applies its typography and terminology standards across multiple content files. The changes focus on consistent formatting of currency values, proper terminology (replacing "Rabatt" with "Ermäßigung"), and correcting a spelling error.

  • Adds a comprehensive German style guide covering typography, spacing, gender-neutral language, and punctuation
  • Standardizes currency formatting with spaces between numbers and currency symbols (e.g., 10€10 €)
  • Replaces "Rabatt" with "Ermäßigung" for consistency in FIP discount terminology
  • Corrects spelling error: "Freifahrtsschein" → "Freifahrtschein"

Reviewed Changes

Copilot reviewed 9 out of 13 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
styleguide_de.md New German style guide document defining typography, spacing, and language standards
content/operator/sncf/index.de.md Corrects spelling of "Freifahrtschein"
content/operator/oebb/index.de.md Standardizes currency spacing and replaces "Rabatt" with "Ermäßigung"
content/operator/gysev/index.de.md Replaces "Rabatt" with "Ermäßigung"
content/operator/eurostar/index.de.md Standardizes currency spacing and replaces "Rabatt" with "Ermäßigung"
content/news/5/index.de.md Standardizes currency spacing throughout
content/country/united-kingdom/index.de.md Replaces "Rabatt" with "Ermäßigung" and adjusts grammatical agreement
content/country/switzerland/index.de.md Standardizes currency spacing
content/country/italy/index.de.md Standardizes currency spacing
content/country/france/index.de.md Replaces "Rabatt" with "Ermäßigung" (appears twice)
content/country/austria/index.de.md Standardizes currency spacing
content/booking/sncf-ticket-office/index.de.md Replaces "Rabatt" with "Ermäßigung"
content/booking/sncf-phone/index.de.md Replaces "Rabatt" with "Ermäßigung" (multiple instances)

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@therobrob therobrob added the content Improvements or additions to the content (countries, news, operators, general content) label Nov 3, 2025
@therobrob
Copy link
Member

Hi Toni, thanks a lot for the styleguide – i've done some content improvements with this :)

Copy link
Member

@MoritzWeber0 MoritzWeber0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The styleguide looks good in general. There will be some additional work to update the content to the new style. But this can be done afterwards in separate PRs.

@therobrob therobrob merged commit 89ad67f into main Nov 16, 2025
7 checks passed
@therobrob therobrob deleted the 356-grammar-check-german branch November 16, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Improvements or additions to the content (countries, news, operators, general content)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grammar check German

4 participants