fix(ai): fix compile error due to session resumption#1852
Open
fix(ai): fix compile error due to session resumption#1852
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the Firebase iOS SDK dependency to version 12.13.0 and adds a handler for the sessionResumptionUpdate case in LiveViewModel. The reviewer correctly identified that the new enum case includes associated values, which requires a pattern match in the switch statement to avoid a compilation error.
…Model.swift Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
ncooke3
approved these changes
May 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per b/507503421,
This PR updates the
LiveViewModelmatch case on the response payload to also have a case for. sessionResumptionUpdate(which was added with firebase-ios-sdk#15904), to fix the compile errors caused from a non exhaustive switch statement.This PR also bumps the min version to align with the
12.13.0release, so it can properly take advantage of this change.