Refactor JobMapComponentState#3653
Merged
andreia-ferreira merged 8 commits intomasterfrom Apr 3, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #3653 +/- ##
============================================
- Coverage 66.58% 66.45% -0.14%
- Complexity 1625 1629 +4
============================================
Files 363 363
Lines 8976 8979 +3
Branches 1147 1154 +7
============================================
- Hits 5977 5967 -10
- Misses 2348 2360 +12
- Partials 651 652 +1
🚀 New features to boost your workflow:
|
shobhitagarwal1612
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Towards #3439 and #3575
This PR focuses on refactoring the
JobMapComponentStatein order to clarify its purpose and prevent the components from maintaining their own state, moving towards a reactive unidirectional data flow, before adding new options to the job sheet (sharing the LOI geometry)The main changes are:
JobMapComponentStateto a sealed interface with mutually exclusive UI statesshowJobSelectionModalstate fromJobMapComponent, since the visibility of that modal has extra logic, which is better placed in the VMJobMapComponentActionwith new actions so that VM can better resolve state@shobhitagarwal1612 PTAL?