Skip to content

Refactor JobMapComponentState #3653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
andreia-ferreira merged 8 commits into from
Apr 3, 2026

add more tests

646130b
Select commit
Loading
Failed to load commit list.
Merged

Refactor JobMapComponentState #3653

add more tests
646130b
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 3, 2026 in 1s

66.45% (-0.14%) compared to ff74695

View this Pull Request on Codecov

66.45% (-0.14%) compared to ff74695

Details

Codecov Report

❌ Patch coverage is 53.57143% with 26 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.45%. Comparing base (ff74695) to head (646130b).

Files with missing lines Patch % Lines
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 0.00% 15 Missing ⚠️
...droid/ui/home/mapcontainer/jobs/JobMapComponent.kt 63.63% 1 Missing and 7 partials ⚠️
...me/mapcontainer/HomeScreenMapContainerViewModel.kt 88.23% 0 Missing and 2 partials ⚠️
.../home/mapcontainer/HomeScreenMapContainerScreen.kt 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #3653      +/-   ##
============================================
- Coverage     66.58%   66.45%   -0.14%     
- Complexity     1625     1629       +4     
============================================
  Files           363      363              
  Lines          8976     8979       +3     
  Branches       1147     1154       +7     
============================================
- Hits           5977     5967      -10     
- Misses         2348     2360      +12     
- Partials        651      652       +1
Files with missing lines Coverage Δ
...oundplatform/android/ui/common/BaseMapViewModel.kt 60.36% <100.00%> (ø)
.../home/mapcontainer/HomeScreenMapContainerScreen.kt 59.25% <0.00%> (-4.38%) ⬇️
...me/mapcontainer/HomeScreenMapContainerViewModel.kt 65.17% <88.23%> (+5.77%) ⬆️
...droid/ui/home/mapcontainer/jobs/JobMapComponent.kt 54.34% <63.63%> (-15.15%) ⬇️
...ome/mapcontainer/HomeScreenMapContainerFragment.kt 29.91% <0.00%> (-6.13%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
View more details on Codecov