Add frame processor support for audio streams (node version) #583
+105
−44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 793ae90 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
… expected by plugin implementations
I think this isn't actually all that helpful for an end user. I'll put this somewhere else instead.
lukasIO
reviewed
Dec 22, 2025
| abstract setEnabled(enabled: boolean): void; | ||
|
|
||
| abstract onStreamInfoUpdated(info: FrameProcessorStreamInfo): void; | ||
| abstract onCredentialsUpdated(credentials: FrameProcessorCredentials): void; |
Contributor
There was a problem hiding this comment.
issue: these two have a default implementation in python and aren't treated as abstract. We should make them non-required also for node.
Author
There was a problem hiding this comment.
Ah, I see, I think I missed that. Fixed!
Some of these aren't even related to this pull request, so I'm quite confused by they are showing up now, I didn't rebase this or something like that...
lukasIO
approved these changes
Dec 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a copy of livekit/python-sdks#533, adapted for node.
I'm letting @lukasIO take the lead on this, and will adjust this once the python version gets merged to match the same interface.