-
Notifications
You must be signed in to change notification settings - Fork 101
Add frame processor support for audio streams (node version) #583
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
1egoman
wants to merge
15
commits into
main
Choose a base branch
from
rg/add-frame-processor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
cd4f084
feat: add frame processor interface
1egoman 3d83af4
feat: add frame processor interface as option for audio stream noise …
1egoman d97a68e
fix: ensure FrameProcessor is using AudioFrame
1egoman 9dc08be
fix: normalize FrameProcessorStreamInfo to contain the same fields as…
1egoman 470bead
feat: add new receive audio through aic example
1egoman 1d57a9f
fix: run pnpm format:write
1egoman 3a90b34
fix: add missing license header
1egoman 9619009
feat: update based off upstream changes to python version
1egoman 646d63e
fix: update example taking into account filter processor changes
1egoman 851e904
feat: add userdata to AudioFrame
1egoman f95c332
feat: remove receive audio through aic filter example
1egoman ac4ef77
fix: add missing changeset
1egoman 39492c9
feat: make onStreamInfoUpdated / onCredentialsUpdated non abstract
1egoman 5f113f9
fix: replace any with unknown
1egoman 793ae90
fix: address a bunch of lint errors
1egoman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| --- | ||
| '@livekit/rtc-node': patch | ||
| --- | ||
|
|
||
| Add frame processor support for audio streams |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| // SPDX-FileCopyrightText: 2025 LiveKit, Inc. | ||
| // | ||
| // SPDX-License-Identifier: Apache-2.0 | ||
| import { type AudioFrame } from './audio_frame.js'; | ||
| import { type VideoFrame } from './video_frame.js'; | ||
|
|
||
| export type FrameProcessorStreamInfo = { | ||
| roomName: string; | ||
| participantIdentity: string; | ||
| publicationSid: string; | ||
| }; | ||
|
|
||
| export type FrameProcessorCredentials = { | ||
| token: string; | ||
| url: string; | ||
| }; | ||
|
|
||
| export abstract class FrameProcessor<Frame extends VideoFrame | AudioFrame> { | ||
| abstract isEnabled(): boolean; | ||
| abstract setEnabled(enabled: boolean): void; | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| onStreamInfoUpdated(_info: FrameProcessorStreamInfo): void {} | ||
| // eslint-disable-next-line @typescript-eslint/no-unused-vars | ||
| onCredentialsUpdated(_credentials: FrameProcessorCredentials): void {} | ||
|
|
||
| abstract process(frame: Frame): Frame; | ||
| abstract close(): void; | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.