fix(frontend): suppress slide animation when entering grid view#228
Merged
Conversation
When switching from swiper to grid view, resetAllSlides() prepends a context batch before the target slide and compensates with an animated slideTo, producing an unwanted horizontal scroll right after the grid fades in. Thread an animatePrepend flag through loadBatch so the initial reset uses 0ms duration; runtime back-scrolling still animates. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resetAllSlides()prepends a context batch before the target slide, andloadBatch()then runsswiper.slideTo(currentColumns, 300, false)to compensate — that 300 ms animation is what was visible.animatePrependflag throughloadBatch(). The initial-reset prepend now passesfalse(0 ms slideTo); runtime back-scrolling keeps the 300 ms animation.Test plan
npm testandnpm run lintpass.🤖 Generated with Claude Code