Skip to content

fix(frontend): suppress slide animation when entering grid view #228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lstein merged 1 commit into from
May 11, 2026
+10 −8
Merged

fix(frontend): suppress slide animation when entering grid view #228

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions photomap/frontend/static/javascript/grid-view.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -364,7 +364,7 @@ class GridViewManager {
// add some context slides before and after
await this.loadBatch(targetIndex + this.slidesPerBatch, true);
if (targetIndex > 0) {
await this.loadBatch(targetIndex - this.slidesPerBatch, false);
await this.loadBatch(targetIndex - this.slidesPerBatch, false, false);
}
} catch (err) {
console.warn(err);
Expand All @@ -374,7 +374,7 @@ class GridViewManager {
this.resetInProgress = false;
}

async loadBatch(startIndex = null, append = true) {
async loadBatch(startIndex = null, append = true, animatePrepend = true) {
const topLeftIndex = Math.floor(startIndex / this.slidesPerBatch) * this.slidesPerBatch;

const placeholderSlides = [];
Expand Down Expand Up @@ -411,12 +411,14 @@ class GridViewManager {
// Use a microtask (Promise) to ensure prepend DOM changes are committed
Promise.resolve().then(() => {
if (this.swiper && !this.swiper.destroyed) {
// Use default speed (300ms) for smooth animation, but suppress slide change event
this.swiper.slideTo(this.currentColumns, 300, false);
// Reset suppressSlideChange after transition completes
setTimeout(() => {
this.suppressSlideChange = false;
}, 350); // Slightly longer than animation duration
const speed = animatePrepend ? 300 : 0;
this.swiper.slideTo(this.currentColumns, speed, false);
setTimeout(
() => {
this.suppressSlideChange = false;
},
animatePrepend ? 350 : 0
);
}
});
}
Expand Down
Loading