fix: register both OAuth redirect URIs to avoid DCR conflict#1119
Open
peschee wants to merge 1 commit intomodelcontextprotocol:mainfrom
Open
fix: register both OAuth redirect URIs to avoid DCR conflict#1119peschee wants to merge 1 commit intomodelcontextprotocol:mainfrom
peschee wants to merge 1 commit intomodelcontextprotocol:mainfrom
Conversation
…normal and debug flows The redirect_uris getter used this.redirectUrl, which DebugInspectorOAuthClientProvider overrides to return the debug URL. This caused Set deduplication to collapse both entries into just the debug URI, so DCR only registered /oauth/callback/debug. The normal Connect flow then failed because /oauth/callback was not a registered redirect URI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/oauth/callback/debug). The normal "Connect" flow then fails because/oauth/callbackis not a registered redirect URI.redirect_urisgetter usedthis.redirectUrl, whichDebugInspectorOAuthClientProvideroverrides to return the debug URL. TheSetdeduplication collapsed both entries into just the debug URI.redirect_urisgetter so they are always registered regardless of which subclass is used.Test plan
npm run build-clientpassescd client && npm run lintpasses