Skip to content

fix: register both OAuth redirect URIs to avoid DCR conflict #1119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
peschee wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: register both OAuth redirect URIs to avoid DCR conflict #1119

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions client/src/lib/auth.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,10 +146,12 @@ export class InspectorOAuthClientProvider implements OAuthClientProvider {
}

get redirect_uris() {
// Normally register both redirect URIs to support both normal and debug flows
// In debug subclass, redirectUrl may be the same as debugRedirectUrl, so remove duplicates
// See: https://github.com/modelcontextprotocol/inspector/issues/825
return [...new Set([this.redirectUrl, this.debugRedirectUrl])];
// Always register both redirect URIs regardless of which subclass is used,
// so that a single client registration works for both normal and debug flows.
return [
window.location.origin + "/oauth/callback",
window.location.origin + "/oauth/callback/debug",
];
}

get clientMetadata(): OAuthClientMetadata {
Expand Down