fix(react): reflect system theme in toggle icon - #1013
Conversation
Signed-off-by: Jonathan Amponsah <82057176+mgalore@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| * Theme switcher. | ||
| */ | ||
| const Toggle = () => { | ||
| const [themePreference, setThemePreference] = useTheme(); |
There was a problem hiding this comment.
this seems like an unrelate rename.
| * @param {boolean} systemSupportsDarkMode - Whether the OS currently prefers dark mode. | ||
| * @returns {'light'|'dark'} The theme currently displayed by the page. | ||
| */ | ||
| export const getDisplayedTheme = (preference, systemSupportsDarkMode) => { |
There was a problem hiding this comment.
@avivkeller I'm fairly sure this can be done on ui-components side? I thought this was done over there already, wondering if a change here is really needed. TRhe solution also doesn feel elegant...
|
also it's not seem fixing the issue |
|
you didn't solve the issue. the goal is not to put what "sytem" preference resolve. the issue is when systems is selected the icon of the button should be the computer. |
|
Thanks for the clarification. I removed the system-theme light/dark overlay; with |
|
This PR accomplishes nothing and will be closed as low effort. For the author, please for the future actually validate what the PR is doing, don't overly rely on AI. It is genuinely a waste of maintainer time when all your replies are AI-generated. Please avoid such contributions in the future. |
3 participants
Summary
systemFixes #903
Validation
npm testnode --run test:cinode --run lintnode --run format:checkSigned-off-by: Jonathan Amponsah 82057176+mgalore@users.noreply.github.com