Skip to content

fix(react): reflect system theme in toggle icon #1013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mgalore wants to merge 3 commits into from
+7 −2
Closed

fix(react): reflect system theme in toggle icon #1013

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e424b9c
fix(react): reflect system theme in toggle icon
mgalore Aug 8, 2026
7d219bc
fix(react): render system theme toggle before hydration
mgalore Aug 10, 2026
1d9cb88
fix(react): keep system toggle icon
mgalore Aug 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bright-themes-guess.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@nodejs/doc-kit-generator-react': patch
---

Show the active light or dark theme icon when the system preference is selected.
4 changes: 2 additions & 2 deletions packages/react/src/html/ui/components/ThemeToggle.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ import withIsland from '../islands/withIsland.jsx';
* Theme switcher.
*/
const Toggle = () => {
const [themePreference, setThemePreference] = useTheme();

@ovflowd ovflowd Aug 9, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this seems like an unrelate rename.

const [currentTheme, setThemePreference] = useTheme();

return (
<ThemeToggle onChange={setThemePreference} currentTheme={themePreference} />
<ThemeToggle onChange={setThemePreference} currentTheme={currentTheme} />
);
};

Expand Down