Skip to content

feat: add back gesture to go up one folder - #4943

Open
alexknop wants to merge 2 commits into
owncloud:masterfrom
alexknop:feature/backgesture
Open

feat: add back gesture to go up one folder#4943
alexknop wants to merge 2 commits into
owncloud:masterfrom
alexknop:feature/backgesture

Conversation

@alexknop

Copy link
Copy Markdown

Related Issues

No logged Issue.

Enhancement: Allow Back Gesture in Android to go back a folder instead of closing the application. If on the root folder, it will exit the application.

App:

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@alexknop
alexknop requested a review from a team as a code owner July 28, 2026 00:28
@jesmrec jesmrec changed the title feat: Add back gesture to go up one folder feat: add back gesture to go up one folder Aug 3, 2026
@jesmrec

jesmrec commented Aug 3, 2026

Copy link
Copy Markdown
Member

@alexknop thanks for the contribution!! we'll check it asap.

As first input, please check the calens file (lacks of endline and description). Get some examples from https://github.com/owncloud/android/tree/master/changelog/

@jesmrec

jesmrec commented Aug 4, 2026

Copy link
Copy Markdown
Member

Thanks for taking care!!, i will give you an extra tips:

  • You updated the branch with a merge commit, we use to rebase branches to prevent extra commits and keeping a cleaner history. It'd be nice to amend it.

  • In case of calens, we noticed you sent two calens commits to the PR. Amending to have only one calens commit is also a good idea. About the content, you can make a shorter description using the Present Perfect Passive tense. Check the template file. My suggestion for your contribution:

Title: Enhancement: Add back gesture

Description: A new gesture has been added in the list of files to browse back to the parent folder instead of closing the app

What do you think?

Summarizing, you can resolve the PR with just two commits: one for the fix, and another one for the calens entry.

By fixing these two small issues, we'll move first to code review and then, to QA. Closer to the final! 🚀

PD: any question or whatever you need, don't hesitate to ping us!!

@alexknop
alexknop force-pushed the feature/backgesture branch from 9990790 to 9b9afa7 Compare August 5, 2026 03:14
@alexknop

alexknop commented Aug 5, 2026

Copy link
Copy Markdown
Author

@jesmrec done!

@joragua joragua left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an easy comment @alexknop! After that it will be moved to QA 😄

Comment thread changelog/unreleased/4943
@@ -0,0 +1,5 @@
Enhancement: Add back gesture to go up a folder instead of closing application

@joragua joragua Aug 5, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd change the calens title:

Suggested change
Enhancement: Add back gesture to go up a folder instead of closing application
Enhancement: Back gesture to go up a folder

NOTE: Do not forget that there must be only one commit for calens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants