workflow: run keywords check weekly#22951
Conversation
There was a problem hiding this comment.
Code Review
This pull request modifies the exit status of the check-keywords.py script to return a binary status (0 or 1) instead of the raw error count. The reviewer suggested using a more idiomatic Python conditional expression 1 if errors else 0 instead of min(errors, 1) to explicitly convey this intent.
dveeden
left a comment
There was a problem hiding this comment.
Only glanced over the changes. Looks fine to me.
[LGTM Timeline notifier]Timeline:
|
4f22024 to
fdc412c
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
What is changed, added or deleted? (Required)
This PR changes the keywords check from a per-PR and push CI gate to a weekly, manually runnable, and repository-dispatch workflow.
After this change, the workflow:
keywords.mdon the configured branches, currentlymasterandrelease-8.5;check-keywords.pyto return0for success and1for any number of mismatches.This reduces unnecessary disruption to unrelated PRs. Previously, every PR could be blocked by a keywords mismatch even when the PR did not touch
keywords.mdor parser-related content (see #22923 (comment)). With the new behavior, keyword drift is still monitored regularly, but it is reported as a maintenance issue instead of interrupting unrelated documentation changes.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?