workflow: run keywords check weekly (#22951)#22953
Conversation
Signed-off-by: ti-chi-bot <ti-community-prow-bot@tidb.io>
|
@qiancai This PR has conflicts, I have hold it. |
|
@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository. |
There was a problem hiding this comment.
Code Review
This pull request updates the scripts/check-keywords.py script to ensure that it exits with a standard status code of 1 if there are errors, or 0 if there are none, rather than exiting with the arbitrary count of errors. There are no review comments to address.
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This is an automated cherry-pick of #22951
What is changed, added or deleted? (Required)
This PR changes the keywords check from a per-PR and push CI gate to a weekly, manually runnable, and repository-dispatch workflow.
After this change, the workflow:
keywords.mdon the configured branches, currentlymasterandrelease-8.5;check-keywords.pyto return0for success and1for any number of mismatches.This reduces unnecessary disruption to unrelated PRs. Previously, every PR could be blocked by a keywords mismatch even when the PR did not touch
keywords.mdor parser-related content (see #22923 (comment)). With the new behavior, keyword drift is still monitored regularly, but it is reported as a maintenance issue instead of interrupting unrelated documentation changes.Which TiDB version(s) do your changes apply to? (Required)
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?