fix: add eager_start as an argument. #15211
Open
+41
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Contributor
|
Thanks you!
Source FTR: python/cpython#128307 Could you reflect it in your PR? |
kevinderuijter
changed the title
Author
|
Thank you for your response and advice. I've reflected my PR by adding |
This comment has been minimized.
This comment has been minimized.
kevinderuijter
changed the title
Contributor
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
donbarbos
suggested changes
Jan 2, 2026
Contributor
donbarbos
left a comment
donbarbos
left a comment
There was a problem hiding this comment.
thanks, I have last suggesion: let's also set the default value as in the documentation
| *, | ||
| name: object = None, | ||
| context: Context | None = None, | ||
| eager_start: bool | None = False, |
Contributor
There was a problem hiding this comment.
Suggested change
| eager_start: bool | None = False, | |
| eager_start: bool | None = None, |
| *, | ||
| name: str | None = None, | ||
| context: Context | None = None, | ||
| eager_start: bool | None = False, |
Contributor
There was a problem hiding this comment.
Suggested change
| eager_start: bool | None = False, | |
| eager_start: bool | None = None, |
| *, | ||
| name: str | None = None, | ||
| context: Context | None = None, | ||
| eager_start: bool | None = False, |
Contributor
There was a problem hiding this comment.
Suggested change
| eager_start: bool | None = False, | |
| eager_start: bool | None = None, |
| if sys.version_info >= (3, 11): | ||
| if sys.version_info >= (3, 14): | ||
| def create_task( | ||
| coro: _CoroutineLike[_T], *, name: str | None = None, context: Context | None = None, eager_start: bool | None = False |
Contributor
There was a problem hiding this comment.
Suggested change
| coro: _CoroutineLike[_T], *, name: str | None = None, context: Context | None = None, eager_start: bool | None = False | |
| coro: _CoroutineLike[_T], *, name: str | None = None, context: Context | None = None, eager_start: bool | None = None |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes eager_start missing in stdlib/asyncio/tasks.pyi #15210