Skip to content

fix: add eager_start as an argument. #15211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kevinderuijter wants to merge 8 commits into
base: main
Choose a base branch
from
+41 −4
Open

fix: add eager_start as an argument. #15211

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
1ce831d
fix: add eager_start as an arugment.
kevinderuijter Jan 2, 2026
cec68bc
fix: add eager_start keyword argument to all create_task functions.
kevinderuijter Jan 2, 2026
08d1e85
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 2, 2026
8b6d55d
fix: forgot to add bool | None.
kevinderuijter Jan 2, 2026
9291771
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Jan 2, 2026
5e1b415
fix: error: asyncio.TaskGroup.create_task is not present in stub
kevinderuijter Jan 2, 2026
2053683
Merge branch 'fix/asyncio.tasks.create_task' of https://github.com/ke…
kevinderuijter Jan 2, 2026
e47bdd8
change object to str for create_task name.
kevinderuijter Jan 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion stdlib/asyncio/base_events.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,16 @@ class BaseEventLoop(AbstractEventLoop):
# Future methods
def create_future(self) -> Future[Any]: ...
# Tasks methods
if sys.version_info >= (3, 11):
if sys.version_info >= (3, 14):
def create_task(
self,
coro: _CoroutineLike[_T],
*,
name: object = None,
context: Context | None = None,
eager_start: bool | None = False,
Copy link
Contributor

@donbarbos donbarbos Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eager_start: bool | None = False,
eager_start: bool | None = None,

) -> Task[_T]: ...
elif sys.version_info >= (3, 11):
def create_task(self, coro: _CoroutineLike[_T], *, name: object = None, context: Context | None = None) -> Task[_T]: ...
else:
def create_task(self, coro: _CoroutineLike[_T], *, name: object = None) -> Task[_T]: ...
Expand Down
12 changes: 11 additions & 1 deletion stdlib/asyncio/events.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,17 @@ class AbstractEventLoop:
@abstractmethod
def create_future(self) -> Future[Any]: ...
# Tasks methods
if sys.version_info >= (3, 11):
if sys.version_info >= (3, 14):
@abstractmethod
def create_task(
self,
coro: _CoroutineLike[_T],
*,
name: str | None = None,
context: Context | None = None,
eager_start: bool | None = False,
Copy link
Contributor

@donbarbos donbarbos Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eager_start: bool | None = False,
eager_start: bool | None = None,

) -> Task[_T]: ...
elif sys.version_info >= (3, 11):
@abstractmethod
def create_task(
self, coro: _CoroutineLike[_T], *, name: str | None = None, context: Context | None = None
Expand Down
15 changes: 14 additions & 1 deletion stdlib/asyncio/taskgroups.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,18 @@ class TaskGroup:

async def __aenter__(self) -> Self: ...
async def __aexit__(self, et: type[BaseException] | None, exc: BaseException | None, tb: TracebackType | None) -> None: ...
def create_task(self, coro: _CoroutineLike[_T], *, name: str | None = None, context: Context | None = None) -> Task[_T]: ...
if sys.version_info >= (3, 14):
def create_task(
self,
coro: _CoroutineLike[_T],
*,
name: str | None = None,
context: Context | None = None,
eager_start: bool | None = False,
Copy link
Contributor

@donbarbos donbarbos Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
eager_start: bool | None = False,
eager_start: bool | None = None,

) -> Task[_T]: ...
else:
def create_task(
self, coro: _CoroutineLike[_T], *, name: str | None = None, context: Context | None = None
) -> Task[_T]: ...

def _on_task_done(self, task: Task[object]) -> None: ...
7 changes: 6 additions & 1 deletion stdlib/asyncio/tasks.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,7 +413,12 @@ else:

def all_tasks(loop: AbstractEventLoop | None = None) -> set[Task[Any]]: ...

if sys.version_info >= (3, 11):
if sys.version_info >= (3, 14):
def create_task(
coro: _CoroutineLike[_T], *, name: str | None = None, context: Context | None = None, eager_start: bool | None = False
Copy link
Contributor

@donbarbos donbarbos Jan 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
coro: _CoroutineLike[_T], *, name: str | None = None, context: Context | None = None, eager_start: bool | None = False
coro: _CoroutineLike[_T], *, name: str | None = None, context: Context | None = None, eager_start: bool | None = None

) -> Task[_T]: ...

elif sys.version_info >= (3, 11):
def create_task(coro: _CoroutineLike[_T], *, name: str | None = None, context: Context | None = None) -> Task[_T]: ...

else:
Expand Down