migrate backends/apple/coreml (TARGETS+BUCK both with rules) by bigfootjon · Pull Request #21429 · pytorch/executorch

bigfootjon · 2026-07-28T16:15:54Z

Summary:
TARGETS contained fbcode-only Python rules (placeholder backend imports);
BUCK contained xplat-only Apple platform cxx_library targets. Created a
new targets.bzl with define_common_targets(is_fbcode = False) whose body
splits via if/else: fbcode branch holds the Python rules, xplat branch
holds the Apple cxx targets. Replaced BUCK with thin caller, deleted
TARGETS.

Differential Revision: D109082057

Summary: Chunk 11 of fbcode/executorch TARGETS->BUCK migration. 5 directories that had only a TARGETS file with substantive fbcode-only content but were skipped from earlier chunks for various reasons (`fbcode_target(`, `fbcode_macros`, fbcode-only kwargs, etc.). Same chunk-6 pattern: created `targets.bzl` with `define_common_targets(is_fbcode = False)` whose body opens with `if not is_fbcode: return`, replaced TARGETS with a thin BUCK calling `define_common_targets(is_fbcode = is_fbcode())`. Directories migrated: - backends/aoti/tests - backends/cuda/runtime - backends/cuda/tests - extension/pybindings/fb - extension/pytree/test Differential Revision: D109082053

Summary: Add is_fbcode param to define_common_targets and early-return outside fbcode. The cxx_test rules use fbcode-only kwargs (keep_gpu_sections, re_test_utils.remote_execution) and were never evaluated in xplat (TARGETS-only pre-migration). Replaced TARGETS with thin BUCK calling define_common_targets(is_fbcode = is_fbcode()). Differential Revision: D109082041

Summary: Add is_fbcode early-return to existing define_common_targets. The cpp_unittest rules use fbcode-only kwargs (keep_gpu_sections, re_test_utils.remote_execution) and can't run in xplat. Replaced TARGETS with thin BUCK. Differential Revision: D109082049

Summary: Add is_fbcode early-return; replace TARGETS with thin BUCK. Differential Revision: D109082042

Summary: TARGETS contained fbcode-only Python rules (placeholder backend imports); BUCK contained xplat-only Apple platform cxx_library targets. Created a new targets.bzl with define_common_targets(is_fbcode = False) whose body splits via if/else: fbcode branch holds the Python rules, xplat branch holds the Apple cxx targets. Replaced BUCK with thin caller, deleted TARGETS. Differential Revision: D109082057

pytorch-bot · 2026-07-28T16:15:58Z

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21429

📄 Preview Python docs built from this PR

Note: Links to docs will display an error until the docs builds have been completed.

❌ 4 New Failures, 1 Unrelated Failure

As of commit a0ef20e with merge base c7b6f52 ():

NEW FAILURES - The following jobs have failed:

Cadence Build & Test / hifi-build / hifi4 (gh)
Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
Cadence Build & Test / vision-build / vision (gh)
Refusing to check out fork pull request code from a 'pull_request_target' workflow. This workflow runs with the base repository's GITHUB_TOKEN, secrets, default-branch cache scope, and runner access. Fetching and executing a fork's code in that trusted context commonly leads to "pwn request" vulnerabilities. To opt in, review the risks at https://gh.io/securely-using-pull_request_target and set 'allow-unsafe-pr-checkout: true' on the actions/checkout step.
pull / unittest-buck / linux / linux-job (gh)
RuntimeError: Command docker exec -t 17d6bbac9c1add03325405df50cbcb74787758c6a2e4c7f995443f7ec5e2d71d /exec failed with exit code 3
pull / unittest-buck / macos / macos-job (gh)
RuntimeError: Command bash /Users/ec2-user/runner/_work/_temp/exec_script failed with exit code 3

FLAKY - The following job failed but was likely due to flakiness present on trunk:

pull / test-models-linux-basic (mv3, xnnpack-quantization-delegation, buck2, linux.2xlarge, executorch-u... / linux-job (gh) (matched linux rule in flaky-rules.json)
The process '/usr/bin/git' failed with exit code 128

This comment was automatically generated by Dr. CI and updates every 15 minutes.

meta-codesync · 2026-07-28T16:16:47Z

@bigfootjon has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109082057.

github-actions · 2026-07-28T16:18:09Z

This PR needs a `release notes:` label

If your change should be included in the release notes (i.e. would users of this library care about this change?), please use a label starting with release notes:. This helps us keep track and include your important work in the next release notes.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "release notes: none"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Copilot

Pull request overview

This PR continues the migration away from standalone TARGETS files by consolidating fbcode-only and xplat-only Buck targets into targets.bzl (with define_common_targets(is_fbcode=...)) and switching directories to a thin BUCK caller that gates behavior via is_fbcode().

Changes:

Introduce/extend define_common_targets(is_fbcode = False) patterns in several directories to preserve fbcode-vs-xplat behavior while deleting TARGETS.
Add thin BUCK entrypoints that call define_common_targets(is_fbcode = is_fbcode()).
Migrate backends/apple/coreml to a single targets.bzl with explicit fbcode/xplat branching and simplify its BUCK.

Reviewed changes

Copilot reviewed 24 out of 24 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
extension/pytree/test/targets.bzl	New gated target definitions (fbcode-only) moved out of `TARGETS`.
extension/pytree/test/TARGETS	Deleted in favor of `targets.bzl` + thin `BUCK`.
extension/pytree/test/BUCK	New thin caller invoking `define_common_targets(is_fbcode=...)`.
examples/models/llama/config/targets.bzl	Gate existing unittest target definitions on `is_fbcode`.
examples/models/llama/config/TARGETS	Deleted; migration to BUCK+targets.bzl calling convention.
examples/models/llama/config/BUCK	New thin caller invoking `define_common_targets(is_fbcode=...)`.
backends/cuda/tests/targets.bzl	New gated CUDA test target definitions moved out of `TARGETS`.
backends/cuda/tests/TARGETS	Deleted in favor of `targets.bzl` + thin `BUCK`.
backends/cuda/tests/BUCK	New thin caller invoking `define_common_targets(is_fbcode=...)`.
backends/cuda/runtime/targets.bzl	New gated CUDA runtime + tests target definitions moved out of `TARGETS`.
backends/cuda/runtime/TARGETS	Deleted in favor of `targets.bzl` + thin `BUCK`.
backends/cuda/runtime/BUCK	New thin caller invoking `define_common_targets(is_fbcode=...)`.
backends/cuda/runtime/shims/tests/targets.bzl	Update common-targets entrypoint to accept `is_fbcode` gating.
backends/cuda/runtime/shims/tests/TARGETS	Deleted in favor of `targets.bzl` + thin `BUCK`.
backends/cuda/runtime/shims/tests/BUCK	New thin caller invoking `define_common_targets(is_fbcode=...)`.
backends/apple/coreml/targets.bzl	New combined fbcode/xplat target definitions with explicit branch split.
backends/apple/coreml/TARGETS	Deleted after moving fbcode Python rules into `targets.bzl`.
backends/apple/coreml/BUCK	Reduced to a thin caller into `targets.bzl` gated by `is_fbcode()`.
backends/aoti/tests/targets.bzl	New gated AOTI test target definitions moved out of `TARGETS`.
backends/aoti/tests/TARGETS	Deleted in favor of `targets.bzl` + thin `BUCK`.
backends/aoti/tests/BUCK	New thin caller invoking `define_common_targets(is_fbcode=...)`.
backends/aoti/slim/factory/test/targets.bzl	Gate existing slim factory tests on `is_fbcode` to preserve prior behavior.
backends/aoti/slim/factory/test/TARGETS	Deleted in favor of `targets.bzl` + thin `BUCK`.
backends/aoti/slim/factory/test/BUCK	New thin caller invoking `define_common_targets(is_fbcode=...)`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+            ":cuda_platform",
+            ":runtime_shims",
+            ":cuda_allocator",
+            ":cuda_platform",
+            "//executorch/backends/aoti:aoti_common_slim",


+            "//executorch/extension/tensor:tensor",
+        ],


 load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
 load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")



+load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
+load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")
+load("@fbcode_macros//build_defs:python_unittest_remote_gpu.bzl", "python_unittest_remote_gpu")
+load("@fbcode_macros//build_defs/lib:re_test_utils.bzl", "re_test_utils")
+


ndmitchell

Review automatically exported from Phabricator review in Meta.

bigfootjon added 5 commits July 28, 2026 08:55

migrate examples/models/llama/config (fbcode-only python_unittest)

4516079

Summary: Add is_fbcode early-return; replace TARGETS with thin BUCK. Differential Revision: D109082042

Copilot AI review requested due to automatic review settings July 28, 2026 16:15

bigfootjon requested review from JacobSzwejbka and shoumikhin as code owners July 28, 2026 16:15

meta-cla Bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Jul 28, 2026

meta-codesync Bot added the meta-exported label Jul 28, 2026

meta-codesync Bot had a problem deploying to cadence July 28, 2026 16:16 Failure

Copilot started reviewing on behalf of bigfootjon July 28, 2026 16:16 View session

Copilot AI reviewed Jul 28, 2026

View reviewed changes

ndmitchell approved these changes Jul 28, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

migrate backends/apple/coreml (TARGETS+BUCK both with rules) - #21429

migrate backends/apple/coreml (TARGETS+BUCK both with rules)#21429
bigfootjon wants to merge 5 commits into
pytorch:mainfrom
bigfootjon:export-D109082057

bigfootjon commented Jul 28, 2026

Uh oh!

pytorch-bot Bot commented Jul 28, 2026 •

edited

Loading

Uh oh!

meta-codesync Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

ndmitchell left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
		load("@fbcode_macros//build_defs:python_unittest.bzl", "python_unittest")

Uh oh!

Conversation

bigfootjon commented Jul 28, 2026

Uh oh!

pytorch-bot Bot commented Jul 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21429

❌ 4 New Failures, 1 Unrelated Failure

Uh oh!

meta-codesync Bot commented Jul 28, 2026

Uh oh!

github-actions Bot commented Jul 28, 2026

This PR needs a release notes: label

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

ndmitchell left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

pytorch-bot Bot commented Jul 28, 2026 •

edited

Loading

This PR needs a `release notes:` label