Skip to content

migrate backends/apple/coreml (TARGETS+BUCK both with rules) #21429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bigfootjon wants to merge 5 commits into
base: main
Choose a base branch
from
Open

migrate backends/apple/coreml (TARGETS+BUCK both with rules) #21429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d9d25d7
gate 5 more fbcode-only TARGETS dirs (no BUCK, no targets.bzl)
bigfootjon Jul 28, 2026
80aaa41
migrate backends/aoti/slim/factory/test (fbcode-only GPU tests)
bigfootjon Jul 28, 2026
2665278
migrate backends/cuda/runtime/shims/tests (fbcode-only CUDA tests)
bigfootjon Jul 28, 2026
4516079
migrate examples/models/llama/config (fbcode-only python_unittest)
bigfootjon Jul 28, 2026
a0ef20e
migrate backends/apple/coreml (TARGETS+BUCK both with rules)
bigfootjon Jul 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions backends/aoti/slim/factory/test/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl.

load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode")
load(":targets.bzl", "define_common_targets")

oncall("executorch")

define_common_targets(is_fbcode = is_fbcode())
3 changes: 0 additions & 3 deletions backends/aoti/slim/factory/test/TARGETS
View file
Open in desktop

This file was deleted.

11 changes: 9 additions & 2 deletions backends/aoti/slim/factory/test/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,15 @@ def get_backend_mode():
"""Get the supported backend mode of slimtensor."""
return ["cuda", "cpu"]

def define_common_targets():
"""Define test targets for SlimTensor factory module."""
def define_common_targets(is_fbcode = False):
"""Define test targets for SlimTensor factory module.

Uses fbcode-only kwargs (keep_gpu_sections, re_test_utils.remote_execution)
so we early-return outside fbcode to preserve pre-migration behavior
(this dir was originally TARGETS-only, never evaluated by xplat).
"""
if not is_fbcode:
return

# GPU empty test with CUDA support
for backend_mode in get_backend_mode():
Expand Down
9 changes: 9 additions & 0 deletions backends/aoti/tests/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl.

load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode")
load(":targets.bzl", "define_common_targets")

oncall("executorch")

define_common_targets(is_fbcode = is_fbcode())
59 changes: 0 additions & 59 deletions backends/aoti/tests/TARGETS
View file
Open in desktop

This file was deleted.

61 changes: 61 additions & 0 deletions backends/aoti/tests/targets.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,61 @@
load("@fbcode_macros//build_defs:cpp_unittest.bzl", "cpp_unittest")
load("@fbcode_macros//build_defs/lib:re_test_utils.bzl", "re_test_utils")

def define_common_targets(is_fbcode = False):
if not is_fbcode:
return

cpp_unittest(
name = "test_resolve_blob_keys",
srcs = [
"test_resolve_blob_keys.cpp",
],
deps = [
"//executorch/backends/aoti:delegate_handle",
"//executorch/runtime/core:core",
"//executorch/runtime/core:evalue",
],
)

cpp_unittest(
name = "test_common_shims",
srcs = [
"test_common_shims.cpp",
],
headers = [
"utils.h",
],
deps = [
"//executorch/backends/aoti:common_shims",
"//executorch/extension/tensor:tensor",
"//executorch/runtime/core:core",
"//executorch/runtime/platform:platform",
"//executorch/runtime/core/exec_aten/testing_util:tensor_util",
"//executorch/runtime/core/exec_aten:lib",
"//executorch/extension/tensor:tensor",
],
Comment on lines +35 to +36
)

cpp_unittest(
name = "test_common_shims_slim",
srcs = [
"test_common_shims_slim.cpp",
],
deps = [
"//executorch/backends/aoti:common_shims_slim",
"//executorch/backends/aoti/slim/core:slimtensor",
"//executorch/backends/aoti/slim/factory:empty",
"//executorch/runtime/core:core",
"//executorch/runtime/platform:platform",
],
external_deps = [
("cuda", None, "cuda-lazy"),
],
preprocessor_flags = [
"-DCUDA_AVAILABLE=1",
],
keep_gpu_sections = True,
remote_execution = re_test_utils.remote_execution(
platform = "gpu-remote-execution",
),
)
183 changes: 4 additions & 179 deletions backends/apple/coreml/BUCK
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,184 +1,9 @@
# Any targets that should be shared between fbcode and xplat must be defined in
# targets.bzl. This file can contain xplat-only targets.
# targets.bzl.

load(
"@fbsource//tools/build_defs:default_platform_defs.bzl",
"APPLE",
)
load("@fbsource//xplat/executorch/build:runtime_wrapper.bzl", "runtime")
load("@fbsource//xplat/executorch/runtime/core:targets.bzl", "build_sdk")
load("@fbsource//tools/build_defs:fbsource_utils.bzl", "is_fbcode")
load(":targets.bzl", "define_common_targets")

oncall("executorch")

runtime.cxx_library(
name = "coreml",
srcs = [
"runtime/delegate/ETCoreMLAsset.mm",
"runtime/delegate/ETCoreMLAssetManager.mm",
"runtime/delegate/ETCoreMLDefaultModelExecutor.mm",
"runtime/delegate/ETCoreMLLogging.mm",
"runtime/delegate/ETCoreMLModel.mm",
"runtime/delegate/ETCoreMLModelCache.mm",
"runtime/delegate/ETCoreMLModelCompiler.mm",
"runtime/delegate/ETCoreMLModelLoader.mm",
"runtime/delegate/ETCoreMLModelManager.mm",
"runtime/delegate/ETCoreMLStrings.mm",
"runtime/delegate/MLModel_Prewarm.mm",
"runtime/delegate/MLMultiArray_Copy.mm",
"runtime/delegate/asset.mm",
"runtime/delegate/backend_delegate.mm",
"runtime/delegate/coreml_backend_delegate.mm",
"runtime/delegate/multiarray.mm",
"runtime/delegate/executorch_operations.mm",
"runtime/delegate/serde_json.mm",
"runtime/inmemoryfs/inmemory_filesystem.cpp",
"runtime/inmemoryfs/inmemory_filesystem_utils.mm",
"runtime/inmemoryfs/memory_buffer.cpp",
"runtime/inmemoryfs/memory_stream.cpp",
"runtime/inmemoryfs/reversed_memory_stream.cpp",
"runtime/kvstore/database.cpp",
"runtime/kvstore/json_key_value_store.cpp",
"runtime/kvstore/key_value_store.cpp",
"runtime/kvstore/sqlite_error.cpp",
"runtime/kvstore/statement.cpp",
"runtime/util/json_util.cpp",
"runtime/util/objc_json_serde.mm",
] + (glob([
"runtime/sdk/*.mm",
]) if build_sdk() else []),
headers = glob([
"runtime/include/coreml_backend/delegate.h",
"runtime/kvstore/*.hpp",
"runtime/inmemoryfs/*.hpp",
"runtime/delegate/*.h",
"runtime/delegate/*.hpp",
"runtime/util/*.h",
"runtime/util/*.hpp",
]) + (glob([
"runtime/sdk/*.h",
]) if build_sdk() else []),
compiler_flags = [
"-fobjc-arc",
"-fno-exceptions",
"-fno-rtti",
"-Wno-null-character",
"-Wno-receiver-expr",
"-Wno-error",
],
define_static_target = True,
header_namespace = "backends/apple/coreml",
exported_headers = ["runtime/delegate/executorch_operations.h", "runtime/include/coreml_backend/delegate.h"],
fbobjc_ios_target_sdk_version = "13.0",
fbobjc_frameworks = [
"Accelerate",
"CoreML",
"Foundation",
],
include_directories = [
"runtime/include",
"runtime/kvstore",
"runtime/inmemoryfs",
"runtime/delegate",
"runtime/util",
] + ([
"runtime/sdk",
] if build_sdk() else []),
fbobjc_libraries = [
"libsqlite3",
],
link_whole = True,
platforms = [APPLE],
visibility = ["PUBLIC"],
deps = [
"//executorch/runtime/backend:backend_options",
"//executorch/runtime/backend:interface",
"//executorch/runtime/core:core",
"//executorch/runtime/kernel:kernel_includes",
] + ([
":proto",
] if build_sdk() else []),
)

_PROTOS = [
"ArrayFeatureExtractor",
"AudioFeaturePrint",
"BayesianProbitRegressor",
"CategoricalMapping",
"ClassConfidenceThresholding",
"CustomModel",
"DataStructures",
"DictVectorizer",
"FeatureTypes",
"FeatureVectorizer",
"Gazetteer",
"GLMClassifier",
"GLMRegressor",
"Identity",
"Imputer",
"ItemSimilarityRecommender",
"LinkedModel",
"MIL",
"Model",
"NearestNeighbors",
"NeuralNetwork",
"NonMaximumSuppression",
"Normalizer",
"OneHotEncoder",
"Parameters",
"Scaler",
"SoundAnalysisPreprocessing",
"SVM",
"TextClassifier",
"TreeEnsemble",
"VisionFeaturePrint",
"WordEmbedding",
"WordTagger",
]

runtime.cxx_test(
name = "coreml_backend_options_test",
srcs = [
"runtime/test/coreml_backend_options_test.cpp",
],
deps = [
":coreml_backend_options",
"//executorch/runtime/backend:backend_options",
"//executorch/runtime/backend:backend_options_map",
"//executorch/runtime/core:core",
],
)

# Header-only library for CoreML backend options
runtime.cxx_library(
name = "coreml_backend_options",
exported_headers = [
"runtime/include/coreml_backend/coreml_backend_options.h",
],
header_namespace = "executorch/backends/apple/coreml",
visibility = ["PUBLIC"],
exported_deps = [
"//executorch/runtime/backend:backend_options",
],
)

runtime.cxx_library(
name = "proto",
srcs = [
"fbsource//third-party/pypi/coremltools:exported-cpp-protoc[{}.pb.cc]".format(name)
for name in _PROTOS
],
exported_headers = {
"format/{}.pb.h".format(name): "fbsource//third-party/pypi/coremltools:exported-cpp-protoc[{}.pb.h]".format(name)
for name in _PROTOS
},
header_namespace = "",
compiler_flags = [
"-Wno-global-constructors",
],
public_include_directories = [
"",
],
deps = [
"//third-party/protobuf:fb-protobuf-lite",
],
)
define_common_targets(is_fbcode = is_fbcode())
Loading
Loading