NXP backend: fixed docs in nxp-quantization.md - #21472
Merged
Merged
Conversation
### Summary Fixed code snippets in `nxp-quantization.md`. - there was an issue with faulty imports, where some kernels were not registered properly. - added missing `neutron_target_spec` argument. - here was another issue with the snippet for QAT. I fixed the code so it can be copy-pasted and run directly. I also removed the optional biasless convolution pass step. It makes the whole snippet quite misleading, since the example MobileNet does not have biasless convolutions, thus the code fails. I think the whole caveat is understandable from the last section about known limitations. - fixed invalid link. ### Test plan No need to run tests, these changes affect only docs. (cherry picked from commit 85a204a)
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/executorch/21472
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit b769ece with merge base cd380e7 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
meta-cla
Bot
added
the
CLA Signed
|
JacobSzwejbka
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed code snippets in
nxp-quantization.md.neutron_target_specargument.Test plan
No need to run tests, these changes affect only docs.
cc @robert-kalmar @JakeStevens @digantdesai @rascani @MartinPavella @roman-janik-nxp