Skip to content

Enable Argo Rollouts support by default#2017

Open
aantn wants to merge 1 commit intomasterfrom
claude/default-argo-rollouts-HabpV
Open

Enable Argo Rollouts support by default#2017
aantn wants to merge 1 commit intomasterfrom
claude/default-argo-rollouts-HabpV

Conversation

@aantn
Copy link
Collaborator

@aantn aantn commented Feb 25, 2026

Summary

This PR enables Argo Rollouts integration by default across the Robusta deployment, changing it from an opt-in to an opt-out feature.

Key Changes

  • Helm values: Changed default argoRollouts from false to true in values.yaml
  • Helm template: Updated runner.yaml to always set the ARGO_ROLLOUTS environment variable, using a ternary operator to conditionally set it to "True" or "False" based on the configuration value (instead of conditionally including the variable)
  • Python configuration: Updated the default value of ARGO_ROLLOUTS from False to True in env_vars.py

Implementation Details

The Helm template change improves consistency by ensuring the ARGO_ROLLOUTS environment variable is always present in the runner pod specification, with its value determined by the configuration setting rather than its presence/absence. This makes the configuration more explicit and easier to debug.

https://claude.ai/code/session_016YtwFoKAXgZ73VWCD2Jyt1

Argo Rollouts discovery is safe to enable by default because the code
gracefully handles the case when the CRD is not installed — the
exception is caught, logged, and discovery continues with other
resource types.

Changes:
- values.yaml: argoRollouts default false -> true
- env_vars.py: ARGO_ROLLOUTS default False -> True
- runner.yaml: always set ARGO_ROLLOUTS env var (supports explicit opt-out)

https://claude.ai/code/session_016YtwFoKAXgZ73VWCD2Jyt1
@github-actions
Copy link

github-actions bot commented Feb 25, 2026

Docker image ready for 43cf042 (built in 2m 42s)

⚠️ Warning: does not support ARM (ARM images are built on release only - not on every PR)

Use this tag to pull the image for testing.

📋 Copy commands

⚠️ Temporary images are deleted after 30 days. Copy to a permanent registry before using them:

gcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:43cf042
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:43cf042 me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:43cf042
docker push me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:43cf042

Patch Helm values in one line:

helm upgrade --install robusta robusta/robusta \
  --reuse-values \
  --set runner.image=me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:43cf042

@coderabbitai
Copy link

coderabbitai bot commented Feb 25, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c5ed072 and 0a083f7.

📒 Files selected for processing (3)
  • helm/robusta/templates/runner.yaml
  • helm/robusta/values.yaml
  • src/robusta/core/model/env_vars.py

Walkthrough

Changes enable ARGO_ROLLOUTS by default across the codebase. Helm template now always defines the environment variable with conditional value, Helm values default changed to true, and Python environment variables default changed to true.

Changes

Cohort / File(s) Summary
ARGO_ROLLOUTS Default Enablement
helm/robusta/templates/runner.yaml, helm/robusta/values.yaml, src/robusta/core/model/env_vars.py
ARGO_ROLLOUTS feature enabled by default. Helm template modified to always define ARGO_ROLLOUTS env var with ternary value instead of conditional block; Helm values and Python env vars defaults changed from false/False to true/True.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title directly and concisely summarizes the main change: enabling Argo Rollouts support by default across all three files modified.
Description check ✅ Passed The description is comprehensive and clearly related to the changeset, detailing the key changes in Helm values, Helm template, and Python configuration with implementation rationale.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
  • 📝 Generate docstrings (stacked PR)
  • 📝 Generate docstrings (commit on current branch)
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch claude/default-argo-rollouts-HabpV

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants