Conversation
Argo Rollouts discovery is safe to enable by default because the code gracefully handles the case when the CRD is not installed — the exception is caught, logged, and discovery continues with other resource types. Changes: - values.yaml: argoRollouts default false -> true - env_vars.py: ARGO_ROLLOUTS default False -> True - runner.yaml: always set ARGO_ROLLOUTS env var (supports explicit opt-out) https://claude.ai/code/session_016YtwFoKAXgZ73VWCD2Jyt1
|
✅ Docker image ready for
Use this tag to pull the image for testing. 📋 Copy commandsgcloud auth configure-docker us-central1-docker.pkg.dev
docker pull us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:43cf042
docker tag us-central1-docker.pkg.dev/robusta-development/temporary-builds/robusta-runner:43cf042 me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:43cf042
docker push me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:43cf042Patch Helm values in one line: helm upgrade --install robusta robusta/robusta \
--reuse-values \
--set runner.image=me-west1-docker.pkg.dev/robusta-development/development/robusta-runner-dev:43cf042 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review infoConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (3)
WalkthroughChanges enable ARGO_ROLLOUTS by default across the codebase. Helm template now always defines the environment variable with conditional value, Helm values default changed to true, and Python environment variables default changed to true. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches
🧪 Generate unit tests (beta)
Comment |
Summary
This PR enables Argo Rollouts integration by default across the Robusta deployment, changing it from an opt-in to an opt-out feature.
Key Changes
argoRolloutsfromfalsetotrueinvalues.yamlrunner.yamlto always set theARGO_ROLLOUTSenvironment variable, using a ternary operator to conditionally set it to "True" or "False" based on the configuration value (instead of conditionally including the variable)ARGO_ROLLOUTSfromFalsetoTrueinenv_vars.pyImplementation Details
The Helm template change improves consistency by ensuring the
ARGO_ROLLOUTSenvironment variable is always present in the runner pod specification, with its value determined by the configuration setting rather than its presence/absence. This makes the configuration more explicit and easier to debug.https://claude.ai/code/session_016YtwFoKAXgZ73VWCD2Jyt1