Skip to content

Enable Argo Rollouts support by default #2017

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aantn wants to merge 1 commit into from
+3 −5
Closed

Enable Argo Rollouts support by default #2017

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions helm/robusta/templates/runner.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,10 +124,8 @@ spec:
- name: IS_OPENSHIFT
value: "True"
{{- end }}
{{- if .Values.argoRollouts }}
- name: ARGO_ROLLOUTS
value: "True"
{{- end }}
value: {{ ternary "True" "False" .Values.argoRollouts | quote }}
{{- if .Values.runner.customCRD }}
- name: CUSTOM_CRD
value: {{ .Values.runner.customCRD | toJson | squote }}
Expand Down
2 changes: 1 addition & 1 deletion helm/robusta/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,7 @@ enablePrometheusStack: false
enabledManagedConfiguration: false
enableServiceMonitors: true
monitorHelmReleases: true
argoRollouts: false
argoRollouts: true



Expand Down
2 changes: 1 addition & 1 deletion src/robusta/core/model/env_vars.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ def load_bool(env_var, default: bool):

RUN_AS_SUBPROCESS = load_bool("RUN_AS_SUBPROCESS", True)

ARGO_ROLLOUTS = load_bool("ARGO_ROLLOUTS", False)
ARGO_ROLLOUTS = load_bool("ARGO_ROLLOUTS", True)
# lowered case k8s kinds in a json array string. "[\"configmap\", \"secret\"]"
RESOURCE_YAML_BLOCK_LIST = json.loads(os.environ.get("RESOURCE_YAML_BLOCK_LIST", "[]"))

Expand Down
Loading