[RF] Fix a memory corruption when initialising a TMatrix.#21311
Open
hageboeck wants to merge 1 commit intoroot-project:masterfrom
Open
[RF] Fix a memory corruption when initialising a TMatrix.#21311hageboeck wants to merge 1 commit intoroot-project:masterfrom
hageboeck wants to merge 1 commit intoroot-project:masterfrom
Conversation
hageboeck
force-pushed
the
rf_matrixBug
branch
from
7378c23 to
4606f1b
Compare
Test Results 22 files 22 suites 3d 10h 49m 9s ⏱️ For more details on these failures, see this check. Results for commit b9a61e9. ♻️ This comment has been updated with latest results. |
The correlation matrix has nine elements, but only 8 were passed to a memcpy that doesn not check the size of the input buffer.
hageboeck
force-pushed
the
rf_matrixBug
branch
from
4606f1b to
b9a61e9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I stumbled over an address sanitizer error when a TMatrix was initialised. It turns out that it got initialised with one element too few, so the element
[2][2]was initialised with random stack memory. Since it seems to be a correlation matrix and the element of the diagonal was missing, I added a1., but please check if that's the correct value.