Deprecate auth package and TNetFile#21775
Open
jblomer wants to merge 30 commits intoroot-project:masterfrom
Open
Deprecate auth package and TNetFile#21775jblomer wants to merge 30 commits intoroot-project:masterfrom
jblomer wants to merge 30 commits intoroot-project:masterfrom
Conversation
jblomer
requested review from
bellenot,
couet,
dpiparo and
pcanal
as code owners
jblomer
changed the title
Test Results 21 files 21 suites 2d 23h 47m 12s ⏱️ For more details on these failures, see this check. Results for commit 0fef1ab. ♻️ This comment has been updated with latest results. |
Member
|
Maybe a small suggestion could be to update the documentation of sockets with something along the lines of 8cbf7e4 . |
Member
|
Regarding rpdutils, see 46eb07a. I think we cannot remove it (yet) without breaking the deprecated functionality. |
silverweed
reviewed
Apr 7, 2026
|
|
||
| } // namespace ROOT::Deprecated | ||
|
|
||
| using TVirtualAuth R__DEPRECATED(6, 42, "TVirtualAuth is deprecated") = ROOT::Deprecated::TVirtualAuth; |
Contributor
There was a problem hiding this comment.
Can we provide alternatives/explanations to users that were relying to this class in the deprecation message? In general it's always good practice to not just say "this is deprecated" but also why it is and/or what to use instead
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
TVirtualAuth, the concrete implementation (auth package), and dependencies:Also removes the unused rpdutils (private library).