Aggregated per-person comments + global comments index - #2059
Merged
Conversation
maebeale
marked this pull request as ready for review
August 4, 2026 05:27
maebeale
changed the title
maebeale
force-pushed
the
maebeale/aggregate-person-comments
branch
from
August 4, 2026 14:46
1a23c42 to
1433b77
Compare
maebeale
force-pushed
the
maebeale/aggregate-person-comments
branch
from
August 5, 2026 03:01
22579e7 to
e500562
Compare
maebeale
changed the base branch from
main
to
maebeale/topic-subscription-comments
August 5, 2026 03:01
maebeale
force-pushed
the
maebeale/topic-subscription-comments
branch
from
August 5, 2026 10:43
4c29fc6 to
66eb247
Compare
maebeale
force-pushed
the
maebeale/aggregate-person-comments
branch
2 times, most recently
from
August 5, 2026 10:53
11d11af to
37bfdf7
Compare
Stacked on the topic-subscription-comments PR (merge that first). - /people/:id/all_comments: one searchable, newest-first feed of every comment connected to a person (profile, registrations, scholarships, CE, topic subscriptions, user account), each tagged with a linked source chip; inline composer (signed-GlobalID target picker) + in-place edit; jump-to-another-person picker. - Global admin comments index (/admin/comments) with the same search boxes + remote person/event filters, linked from admin home. - Makes CE registrations commentable; adds nested comment routes + set_commentable branches for scholarships, CE, and topic subscriptions (for the aggregated feed's inline edit). - "View all" links from each record's comment box to the person's report. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/aggregate-person-comments
branch
from
August 5, 2026 12:04
37bfdf7 to
2860a05
Compare
The aggregated person-comments page and the global comments index weren't recorded in Ahoy. Fire a distinct view event on each full-page load (not the Turbo-frame filter requests): view.person_all_comments (with person_id) and view.comments (page: index). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
On the global comments index, the person and event remote-selects now sit together on a second filter row instead of wrapping in with the keyword/author/type/date filters. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 5 Inspect 🔬 new admin pages, shared CommentsController create/update branch, new commentable model/routes, search scopes
What is the goal of this PR and why is this important?
How did you approach the change?
PersonCommentAggregatorunions comments across profile + registrations + scholarships + CE + topic subscriptions + user account.ContinuingEducationRegistrationcommentable; adds nested comment routes +set_commentablebranches for scholarships, CE, and topic subscriptions (for the feed's inline edit). Payments stay non-commentable.CommentsController#create/#updatevia anaggregatedflag; the composer posts the chosen record as a signed GlobalID resolved server-side (no JS action-swapping).CommentsHelper#commentable_label+CommentDecoratorgive each row/source its label, link, and theme. "View all" links from every record's comment box to the person's report.Anything else to add?