Add comments to topic subscriptions - #2098
Merged
Merged
Conversation
maebeale
marked this pull request as ready for review
August 5, 2026 02:56
maebeale
marked this pull request as draft
August 5, 2026 03:02
Make TopicSubscription commentable and replace the form's free-text "Note" field with a save-with-record comments box (converted to simple_form_for + cocoon nested fields). Add a Comments filter (has comments / flagged / none) to the index, and drop the now-unused note column via a reversible migration. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maebeale
force-pushed
the
maebeale/topic-subscription-comments
branch
from
August 5, 2026 10:43
4c29fc6 to
66eb247
Compare
The "unrelated edit" test used note:; use source: now that note is gone. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 suggested review level: 3 Read 📖 small, contained: one model made commentable, a form field swap, a filter, and a column-drop migration
What is the goal of this PR and why is this important?
How did you approach the change?
TopicSubscriptioncommentable (nested attrs).simple_form_for+ cocoon nested fields).notecolumn (reversible migration).Anything else to add?
notevalues (feature is new; column had little/no data).