chore: use more workspace-wide configurations#4061
Merged
rami3l merged 4 commits intorust-lang:masterfrom Oct 25, 2024
Merged
Conversation
ChrisDenton
approved these changes
Oct 24, 2024
Member
ChrisDenton
left a comment
There was a problem hiding this comment.
Workspace inheritance is more verbose than I'd like but only setting information in one place is definitely an advantage.
djc
reviewed
Oct 25, 2024
This was referenced Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does the following cleanup WRT
Cargo.toml:Cargo.tomlto use workspace settings forversion,edition, andlicensefields (cherry-picked from dist: bumprustupversion to1.28.0#4041) [1] [2]Cargo.toml,download/Cargo.toml) [1] [2]This also prepares the repo for its upcoming migration to Rust 2024 by making it easier to enable
rust-2024-compatibilityacross the project. With this change, that will look like: