Throw AdapterError instead of Error when variable env var is missing#766
Merged
Throw AdapterError instead of Error when variable env var is missing#766
Conversation
Contributor
NPM Publishing labels 🏷️🟢 This PR has valid version labels and will cause a |
mohamed-mehany
approved these changes
May 8, 2026
Contributor
|
🚀 Successfully created version bump PR: #767 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Most errors thrown in
src/config/index.tsare thrown during adapter initialization.But the error that's thrown when a required variable env var is missing, is likely to be thrown during request validation.
By making it an
AdapterErrorinstead ofError, the adapter will returns a proper json response withstatusCodeinstead of just a string.Changes
Throw
AdapterErrorinstead ofErrorwhen a required variable env var is missing when requested.Testing
Used with
proof-of-reserves-v2in the EA repo.