Skip to content

Throw AdapterError instead of Error when variable env var is missing #766

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dskloetc merged 1 commit into from
May 8, 2026
Merged

Throw AdapterError instead of Error when variable env var is missing #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/config/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import CensorList, { CensorKeyValue } from '../util/censor/censor-list'
import { AdapterError } from '../validation/error'
import { Validator, validator } from '../validation/utils'

export const BaseSettingsDefinition = {
Expand Down Expand Up @@ -597,7 +598,10 @@ export class EnvGetter<
this.name.replace(this.settingsDefinition.variablePlaceholder, canonicalVariable),
this.prefix,
)
throw new Error(`Missing required environment variable: ${envName}`)
throw new AdapterError({
statusCode: 500,
message: `Missing required environment variable: ${envName}`,
})
}

entries(): VariableEnvVarEntry<SettingTypeWhenPresent<T>>[] {
Expand Down
4 changes: 3 additions & 1 deletion test/config.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
SettingDefinition,
SettingsDefinitionMap,
} from '../src/config'
import { AdapterError } from '../src/validation/error'
import { validator } from '../src/validation/utils'
import { Adapter } from '../src/adapter'
import { buildSettingsList } from '../src/util/settings'
Expand Down Expand Up @@ -317,7 +318,8 @@ test.serial('Get required variable env var', async (t) => {
config.settings.NETWORK_RPC_URL.get('arbitrum')
t.fail()
} catch (error) {
t.is((error as Error).message, 'Missing required environment variable: ARBITRUM_RPC_URL')
t.is((error as AdapterError).message, 'Missing required environment variable: ARBITRUM_RPC_URL')
t.is((error as AdapterError).statusCode, 500)
}
})

Expand Down
Loading