Skip to content

Conversation

@dgholz
Copy link

@dgholz dgholz commented Dec 12, 2024

Description

Allow users to leave the default endpoint enabled when a custom domain is set.

Motivation and Context

Setting the disable_execute_api_endpoint variable to false should leave the default endpoint enabled when a custom domain is set.
This change resolves #128
This change also preserves the existing behaviour of disabling the default endpoint when a custom domain is set & no value was given for the disable_execute_api_endpoint variable.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have used this change in my own Terraform module to see that the default endpoint was not disabled
  • I have executed pre-commit run -a on my pull request

@dgholz
Copy link
Author

dgholz commented Dec 12, 2024

I'm happy to add an example to cover this behaviour, but would appreciate some guidance on where to put it & what to include.

@dgholz dgholz changed the title Defer to user-supplied input before disabling execute-api endpoint fix: defer to user-supplied input before disabling execute-api endpoint Dec 12, 2024
@dgholz dgholz changed the title fix: defer to user-supplied input before disabling execute-api endpoint fix: Defer to user-supplied input before disabling execute-api endpoint Dec 12, 2024
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 12, 2025
@github-actions
Copy link

This PR was automatically closed because of stale in 10 days

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set disable_execute_api_endpoint to False doesn't Work

1 participant