Skip to content

fix: Defer to user-supplied input before disabling execute-api endpoint #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dgholz wants to merge 1 commit into from
Closed

fix: Defer to user-supplied input before disabling execute-api endpoint #130

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ locals {
is_websocket = var.protocol_type == "WEBSOCKET"

create_routes_and_integrations = var.create && var.create_routes_and_integrations
disable_execute_api_endpoint = var.disable_execute_api_endpoint != null ? var.disable_execute_api_endpoint : local.is_http && local.create_domain_name
}

################################################################################
Expand Down Expand Up @@ -31,7 +32,7 @@ resource "aws_apigatewayv2_api" "this" {
credentials_arn = local.is_http ? var.credentials_arn : null
description = var.description
# https://docs.aws.amazon.com/apigateway/latest/developerguide/rest-api-disable-default-endpoint.html
disable_execute_api_endpoint = local.is_http && local.create_domain_name ? true : var.disable_execute_api_endpoint
disable_execute_api_endpoint = local.disable_execute_api_endpoint
fail_on_warnings = local.is_http ? var.fail_on_warnings : null
name = var.name
protocol_type = var.protocol_type
Expand Down
Loading