fix(api-call): retry on 500s / 408s #97
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove duplicate `$statusCode` variable assignment in `ApiCall.php` - clean up redundant conditional check for status code 408 - simplify exception handling flow for better code readability
- Add `ApiCallRetryTest.php` with tests for exception handling scenarios - Test retry logic for server errors, client errors, and timeout responses - Verify 4xx errors are not retried while 5xx errors trigger retries - Test node health check updates after failed requests - Ensure 408 timeout errors are skipped and retrying continues
jasonbosco
requested changes
Jul 14, 2025
tharropoulos
commented
Jul 15, 2025
Contributor
Author
|
Now also addresses #100 |
- refactor exception handling to separate typesense client errors from network errors - fix sleep logic to only execute between retry attempts, not after final attempt - add test to verify no sleep occurs on final retry attempt with timing validation
tharropoulos
force-pushed
the
dont-throw-on-node-retry
branch
from
69b19dc to
33d30dc
Compare
Contributor
Author
jasonbosco
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Fix #96 by adding checks for 400-ranged statuses, in order to throw when the call first gets a 400-ranged response.
PR Checklist