Skip to content

fix(api-call): retry on 500s / 408s #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonbosco merged 5 commits into from
Aug 15, 2025
Merged

fix(api-call): retry on 500s / 408s #97

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
10f7229
fix: don't throw while retrying
anthonybachour Jun 18, 2025
591455c
fix(api): throw on first case of 400s
tharropoulos Jun 24, 2025
8efbdd6
test(api): add retry mechanism tests for `ApiCall` class
tharropoulos Jun 24, 2025
33d30dc
fix: prevent sleep on final retry attempt in api call
tharropoulos Jul 16, 2025
d2c1f45
Merge branch 'master' into dont-throw-on-node-retry
jasonbosco Aug 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
36 changes: 25 additions & 11 deletions src/ApiCall.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,26 +266,40 @@ private function makeRequest(string $method, string $endPoint, bool $asJson, arr
->getContents(), true, 512, JSON_THROW_ON_ERROR) : $response->getBody()
->getContents();
} catch (HttpException $exception) {
if (
$exception->getResponse()
->getStatusCode() === 408
) {
$statusCode = $exception->getResponse()->getStatusCode();

// Skip 408 timeouts and continue to next iteration
if ($statusCode === 408) {
continue;
}

// For 4xx errors, don't retry - throw immediately
if (400 <= $statusCode && $statusCode < 500) {
$this->setNodeHealthCheck($node, false);
throw $this->getException($statusCode)
->setMessage($exception->getMessage());
}

// For 5xx errors, set exception and continue to retry logic
$this->setNodeHealthCheck($node, false);
throw $this->getException($exception->getResponse()
->getStatusCode())
$lastException = $this->getException($statusCode)
->setMessage($exception->getMessage());
} catch (TypesenseClientError | HttpClientException $exception) {
} catch (HttpClientException $exception) {
// For network errors, set exception and continue to retry logic
$this->setNodeHealthCheck($node, false);
throw $exception;
$lastException = $exception;
} catch (Exception $exception) {
if ($exception instanceof TypesenseClientError) {
throw $exception;
}

$this->setNodeHealthCheck($node, false);
$lastException = $exception;
if ($numRetries < $this->config->getNumRetries() + 1) {
sleep($this->config->getRetryIntervalSeconds());
}
}

if ($numRetries < $this->config->getNumRetries() + 1) {
usleep((int) ($this->config->getRetryIntervalSeconds() * 10**6));
}
}

if ($lastException) {
Expand Down
Loading