Conversation
There was a problem hiding this comment.
Pull request overview
This pull request migrates the project from using external TypeScript tooling (tsx) to Node.js native TypeScript support via the --experimental-strip-types flag. This modernizes the development workflow to leverage built-in Node.js capabilities.
Changes:
- Replaced tsx with Node.js
--experimental-strip-typesflag for development and testing - Updated TypeScript configuration to use inline compiler options instead of extending from @sindresorhus/tsconfig
- Changed all relative imports from
.jsto.tsextensions and adoptedimport typesyntax for type-only imports
Reviewed changes
Copilot reviewed 6 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tsconfig.json | Replaced external config extension with inline compiler options for Node.js native TS support |
| src/service.test.ts | Updated imports to use .ts extensions and split type imports |
| src/observer.ts | Changed Adapter import to type-only import |
| src/bin.ts | Updated imports to .ts extensions and split type-only imports |
| src/app.ts | Updated imports to .ts extensions, split type imports, removed resolved @ts-expect-error comment |
| src/app.test.ts | Updated imports to use .ts extensions and type-only import syntax |
| package.json | Updated scripts to use Node.js native TS, removed tsx dependency, updated dependency versions |
| pnpm-lock.yaml | Updated lockfile reflecting dependency changes |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "@tinyhttp/app": "^3.0.1", | ||
| "@tinyhttp/cors": "^2.0.1", | ||
| "@tinyhttp/logger": "^2.0.0", | ||
| "@tinyhttp/logger": "^2.1.0", | ||
| "chalk": "^5.3.0", | ||
| "chokidar": "^4.0.1", | ||
| "chokidar": "^5.0.0", |
There was a problem hiding this comment.
Major version updates for @tinyhttp/app (2.4.0 → 3.0.1) and chokidar (4.0.1 → 5.0.0) may introduce breaking changes. While these updates are included in the lockfile, ensure that the application has been tested with these new versions and that no breaking changes affect the codebase. Review the changelogs for these packages to understand what changed.
| "get-port": "^7.1.0", | ||
| "husky": "^9.1.6", | ||
| "oxlint": "^1.39.0", | ||
| "oxlint": "^1.38.0", |
There was a problem hiding this comment.
The oxlint package version has been downgraded from ^1.39.0 to ^1.38.0. This appears to be a regression rather than an intentional change, as package updates typically move forward. Consider updating to the latest available version instead of downgrading.
| "oxlint": "^1.38.0", | |
| "oxlint": "^1.39.0", |
No description provided.