chore(deps)!: upgrade to utopia-php/pools 2.x - #118
Conversation
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Greptile SummaryThis PR upgrades the Pools dependency stack to 2.x.
Confidence Score: 4/5The PR is not safe to merge until its declared PHP support is aligned with the PHP 8.5 minimum imposed by the upgraded dependencies. The root manifest and CI still support PHP 8.4, but Database 7.0.0 and Validators 0.3.1 require PHP 8.5, so ordinary dependency installation on a declared-supported platform fails. Files Needing Attention: composer.json and composer.lock Important Files Changed
Prompt To Fix All With AI### Issue 1
composer.json:25
**PHP 8.4 installs are broken**
When a consumer runs Composer on PHP 8.4, which the root manifest permits, the new Database 7.x constraint resolves to packages requiring PHP 8.5, causing dependency installation to fail with an unsatisfied platform requirement.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Reviews (2): Last reviewed commit: "chore(deps): bump utopia-php/database to..." | Re-trigger Greptile |
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
| "ext-redis": "*", | ||
| "utopia-php/database": "^6.0.0", | ||
| "utopia-php/pools": "1.*", | ||
| "utopia-php/database": "^7.0.0", |
There was a problem hiding this comment.
When a consumer runs Composer on PHP 8.4, which the root manifest permits, the new Database 7.x constraint resolves to packages requiring PHP 8.5, causing dependency installation to fail with an unsatisfied platform requirement.
Prompt To Fix With AI
This is a comment left during a code review.
Path: composer.json
Line: 25
Comment:
**PHP 8.4 installs are broken**
When a consumer runs Composer on PHP 8.4, which the root manifest permits, the new Database 7.x constraint resolves to packages requiring PHP 8.5, causing dependency installation to fail with an unsatisfied platform requirement.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
Pools 2.0 makes configuration constructor-only and replaces the retry knobs with a single acquisition budget.
TimeLimit\RedisPoolonly ever calls$pool->use(), which is unchanged, so the adapter itself needs no edits. The only code changes are the pool constructions inRedisPoolTestandRedisPoolClusterTest, which now pass the requiredtimeout.Needed so that appwrite/appwrite can move to pools 2 —
utopia-php/abuseis one of the packages still pinningpools 1.*and blocking resolution.Blocked on utopia-php/database#928 (itself blocked on utopia-php/cache#82).
utopia-php/databaseis a hard requirement here and still pinspools 1.*, socomposer.lockcannot be regenerated until that lands and is tagged. The lock is intentionally left untouched in this PR and needs a refresh before merge — CI will be red until then.Release order:
utopia-php/cache,utopia-php/database, then this.🤖 Generated with Claude Code