Skip to content

chore(deps)!: upgrade to utopia-php/pools 2.x - #118

Merged
loks0n merged 2 commits into
mainfrom
chore/pools-2
Jul 31, 2026
Merged

chore(deps)!: upgrade to utopia-php/pools 2.x#118
loks0n merged 2 commits into
mainfrom
chore/pools-2

Conversation

@loks0n

@loks0n loks0n commented Jul 31, 2026

Copy link
Copy Markdown
Contributor

Pools 2.0 makes configuration constructor-only and replaces the retry knobs with a single acquisition budget.

TimeLimit\RedisPool only ever calls $pool->use(), which is unchanged, so the adapter itself needs no edits. The only code changes are the pool constructions in RedisPoolTest and RedisPoolClusterTest, which now pass the required timeout.

Needed so that appwrite/appwrite can move to pools 2 — utopia-php/abuse is one of the packages still pinning pools 1.* and blocking resolution.

Blocked on utopia-php/database#928 (itself blocked on utopia-php/cache#82). utopia-php/database is a hard requirement here and still pins pools 1.*, so composer.lock cannot be regenerated until that lands and is tagged. The lock is intentionally left untouched in this PR and needs a refresh before merge — CI will be red until then.

Release order: utopia-php/cache, utopia-php/database, then this.

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@greptile-apps

greptile-apps Bot commented Jul 31, 2026

Copy link
Copy Markdown

Greptile Summary

This PR upgrades the Pools dependency stack to 2.x.

  • Upgrades Database to 7.x and refreshes related locked dependencies.
  • Supplies the required acquisition timeout when constructing Redis pools in tests.

Confidence Score: 4/5

The PR is not safe to merge until its declared PHP support is aligned with the PHP 8.5 minimum imposed by the upgraded dependencies.

The root manifest and CI still support PHP 8.4, but Database 7.0.0 and Validators 0.3.1 require PHP 8.5, so ordinary dependency installation on a declared-supported platform fails.

Files Needing Attention: composer.json and composer.lock

Important Files Changed

Filename Overview
composer.json Upgrades Database and Pools constraints, but the resolved Database release raises the effective PHP minimum beyond the root package's declared range.
composer.lock Refreshes the Pools-related dependency graph and records Database and Validators releases requiring PHP 8.5.
tests/Abuse/RedisPoolTest.php Updates standalone Redis pool construction for the Pools 2.x constructor contract.
tests/Abuse/RedisPoolClusterTest.php Updates clustered Redis pool construction for the Pools 2.x constructor contract.

Fix All in Claude Code Fix All in Codex

Prompt To Fix All With AI
### Issue 1
composer.json:25
**PHP 8.4 installs are broken**

When a consumer runs Composer on PHP 8.4, which the root manifest permits, the new Database 7.x constraint resolves to packages requiring PHP 8.5, causing dependency installation to fail with an unsatisfied platform requirement.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (2): Last reviewed commit: "chore(deps): bump utopia-php/database to..." | Re-trigger Greptile

Comment thread composer.json
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Comment thread composer.json
"ext-redis": "*",
"utopia-php/database": "^6.0.0",
"utopia-php/pools": "1.*",
"utopia-php/database": "^7.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 PHP 8.4 installs are broken

When a consumer runs Composer on PHP 8.4, which the root manifest permits, the new Database 7.x constraint resolves to packages requiring PHP 8.5, causing dependency installation to fail with an unsatisfied platform requirement.

Prompt To Fix With AI
This is a comment left during a code review.
Path: composer.json
Line: 25

Comment:
**PHP 8.4 installs are broken**

When a consumer runs Composer on PHP 8.4, which the root manifest permits, the new Database 7.x constraint resolves to packages requiring PHP 8.5, causing dependency installation to fail with an unsatisfied platform requirement.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code Fix in Codex

@loks0n
loks0n merged commit 460d941 into main Jul 31, 2026
6 checks passed
@loks0n
loks0n deleted the chore/pools-2 branch July 31, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant