Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -22,8 +22,8 @@
"ext-pdo": "*",
"ext-curl": "*",
"ext-redis": "*",
"utopia-php/database": "^6.0.0",
"utopia-php/pools": "1.*",
"utopia-php/database": "^7.0.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 PHP 8.4 installs are broken

When a consumer runs Composer on PHP 8.4, which the root manifest permits, the new Database 7.x constraint resolves to packages requiring PHP 8.5, causing dependency installation to fail with an unsatisfied platform requirement.

Prompt To Fix With AI
This is a comment left during a code review.
Path: composer.json
Line: 25

Comment:
**PHP 8.4 installs are broken**

When a consumer runs Composer on PHP 8.4, which the root manifest permits, the new Database 7.x constraint resolves to packages requiring PHP 8.5, causing dependency installation to fail with an unsatisfied platform requirement.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Fix in Claude Code Fix in Codex

"utopia-php/pools": "2.*",
Comment thread
greptile-apps[bot] marked this conversation as resolved.
"appwrite/appwrite": "^26.0"
},
"require-dev": {
Expand Down
93 changes: 47 additions & 46 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion tests/Abuse/RedisPoolClusterTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ public static function setUpBeforeClass(): void
'redis-cluster-2:6379',
'redis-cluster-3:6379',
]);
});
}, timeout: 0.0);
}

public function getAdapter(string $key, int $limit, int $seconds): TimeLimit
Expand Down
2 changes: 1 addition & 1 deletion tests/Abuse/RedisPoolTest.php
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public static function setUpBeforeClass(): void
$redis->connect('redis', 6379);

return $redis;
});
}, timeout: 0.0);
}

public function getAdapter(string $key, int $limit, int $seconds): TimeLimit
Expand Down
Loading