Open
Conversation
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk> # Conflicts: # encodings/fastlanes/src/bitpacking/vtable/mod.rs # vortex-array/src/vtable/mod.rs
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
Merging this PR will degrade performance by 21.7%
Performance Changes
Comparing 
Footnotes
|
Contributor
Polar Signals Profiling ResultsLatest Run
Previous Runs (5)
Powered by Polar Signals Cloud |
Contributor
Benchmarks: PolarSignals ProfilingVortex (geomean): 1.010x ➖ datafusion / vortex-file-compressed (1.010x ➖, 0↑ 0↓)
|
Contributor
Benchmarks: TPC-H SF=1 on NVMEVerdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.221x ❌, 0↑ 22↓)
datafusion / vortex-compact (1.193x ❌, 0↑ 20↓)
datafusion / parquet (1.145x ❌, 0↑ 16↓)
datafusion / arrow (0.990x ➖, 1↑ 1↓)
duckdb / vortex-file-compressed (1.227x ❌, 0↑ 22↓)
duckdb / vortex-compact (1.187x ❌, 0↑ 21↓)
duckdb / parquet (1.110x ❌, 0↑ 13↓)
duckdb / duckdb (1.102x ❌, 0↑ 13↓)
Full attributed analysis
|
Contributor
Benchmarks: FineWeb NVMeVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (1.012x ➖, 2↑ 0↓)
datafusion / vortex-compact (1.026x ➖, 0↑ 0↓)
datafusion / parquet (1.032x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (1.035x ➖, 0↑ 3↓)
duckdb / vortex-compact (1.027x ➖, 0↑ 0↓)
duckdb / parquet (1.030x ➖, 0↑ 0↓)
Full attributed analysis
|
robert3005
reviewed
Apr 1, 2026
Contributor
Benchmarks: TPC-DS SF=1 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.991x ➖, 1↑ 0↓)
datafusion / vortex-compact (0.987x ➖, 0↑ 0↓)
datafusion / parquet (0.986x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.982x ➖, 1↑ 0↓)
duckdb / vortex-compact (0.984x ➖, 3↑ 0↓)
duckdb / parquet (0.988x ➖, 1↑ 0↓)
duckdb / duckdb (0.967x ➖, 11↑ 2↓)
Full attributed analysis
|
Contributor
Benchmarks: TPC-H SF=10 on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.989x ➖, 0↑ 0↓)
datafusion / vortex-compact (0.994x ➖, 0↑ 0↓)
datafusion / parquet (0.998x ➖, 0↑ 0↓)
datafusion / arrow (0.985x ➖, 0↑ 0↓)
duckdb / vortex-file-compressed (0.991x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.003x ➖, 0↑ 0↓)
duckdb / parquet (1.001x ➖, 0↑ 0↓)
duckdb / duckdb (0.992x ➖, 1↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: TPC-H SF=1 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (1.232x ➖, 4↑ 11↓)
datafusion / vortex-compact (0.720x ➖, 8↑ 0↓)
datafusion / parquet (1.137x ➖, 4↑ 8↓)
duckdb / vortex-file-compressed (0.934x ➖, 1↑ 1↓)
duckdb / vortex-compact (0.973x ➖, 0↑ 0↓)
duckdb / parquet (1.030x ➖, 0↑ 1↓)
Full attributed analysis
|
Contributor
Benchmarks: FineWeb S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.934x ➖, 1↑ 1↓)
datafusion / vortex-compact (0.937x ➖, 2↑ 0↓)
datafusion / parquet (1.092x ➖, 0↑ 2↓)
duckdb / vortex-file-compressed (0.881x ➖, 0↑ 0↓)
duckdb / vortex-compact (1.055x ➖, 0↑ 3↓)
duckdb / parquet (0.972x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Random AccessVortex (geomean): 0.909x ➖ unknown / unknown (0.994x ➖, 7↑ 5↓)
|
Contributor
Benchmarks: Statistical and Population GeneticsVerdict: No clear signal (low confidence) duckdb / vortex-file-compressed (1.053x ➖, 0↑ 2↓)
duckdb / vortex-compact (1.078x ➖, 0↑ 1↓)
duckdb / parquet (1.024x ➖, 0↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: Clickbench on NVMEVerdict: No clear signal (low confidence) datafusion / vortex-file-compressed (0.990x ➖, 0↑ 1↓)
datafusion / parquet (0.989x ➖, 1↑ 0↓)
duckdb / vortex-file-compressed (1.003x ➖, 2↑ 7↓)
duckdb / parquet (0.993x ➖, 0↑ 0↓)
duckdb / duckdb (0.948x ➖, 4↑ 0↓)
Full attributed analysis
|
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Contributor
Benchmarks: TPC-H SF=10 on S3Verdict: No clear signal (environment too noisy confidence) datafusion / vortex-file-compressed (0.939x ➖, 4↑ 1↓)
datafusion / vortex-compact (0.937x ➖, 4↑ 3↓)
datafusion / parquet (0.730x ➖, 9↑ 0↓)
duckdb / vortex-file-compressed (0.923x ➖, 0↑ 0↓)
duckdb / vortex-compact (0.981x ➖, 0↑ 0↓)
duckdb / parquet (0.973x ➖, 1↑ 0↓)
Full attributed analysis
|
Contributor
Benchmarks: CompressionVortex (geomean): 1.088x ➖ unknown / unknown (1.065x ➖, 3↑ 10↓)
|
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
Signed-off-by: Joe Isaacs <joe.isaacs@live.co.uk>
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
joseph-isaacs
force-pushed
the
ji/mut-slots
branch
from
86e00b8 to
e48e277
Compare
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
joseph-isaacs
added
the
action/benchmark
github-actions
bot
removed
the
action/benchmark
robert3005
reviewed
Apr 2, 2026
| slots[slot_idx] = Some(replacement); | ||
| /// Requires unique ownership of the `ArrayRef` (panics if Arc refcount > 1). | ||
| pub fn take_slot(self: &mut ArrayRef, slot_idx: usize) -> Option<ArrayRef> { | ||
| let vtable = self.vtable().clone_boxed(); |
Contributor
There was a problem hiding this comment.
part of me wants to do unsafe things here to erase lifetimes and get rid of this clone. Replacing a slot wouldn't touch the vtable
Contributor
Author
There was a problem hiding this comment.
This free for zst (all out current VTables).
Contributor
There was a problem hiding this comment.
yea we discussed this offline with Joe, it is a bit weird to have this hidden cost creep up depending on whether you cloned the array before or not. if Arc refcount is one we do a different thing, so that kinda defeats the purpose of ArrayRef.clone being cheap. Clone is cheap but execute just became more expensive because you cloned
onursatici
requested changes
Apr 2, 2026
Contributor
onursatici
left a comment
onursatici
left a comment
There was a problem hiding this comment.
can you rebase so we know for certain that the wide table decompression is still fast after these changes. Currently I don't think your branch includes today's fix
Contributor
Author
|
I did locally and it was. I can do this but would prefer to fix after the fact |
onursatici
approved these changes
Apr 2, 2026
robert3005
reviewed
Apr 2, 2026
| mask: &Mask, | ||
| ctx: &mut ExecutionCtx, | ||
| ) -> VortexResult<VariantArray> { | ||
| let child = array.child().clone(); |
Contributor
There was a problem hiding this comment.
can you remove the clone here?
Contributor
Author
There was a problem hiding this comment.
is a follow up okay?
robert3005
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the temp
with_slotswith aslot_mutmethod this allows for arrays mutate the children inplace.