Skip to content

feat: Add French language #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
lenderom merged 25 commits into from
Jul 21, 2025
Merged

feat: Add French language #239

lenderom merged 25 commits into from
Jul 21, 2025

Conversation

@antvgr
Copy link
Contributor

@antvgr antvgr commented Jul 14, 2025 •
edited by lenderom
Loading

Description

Add french translation to all pages except news.

Checklist

  • Check the License of new pictures (non-commercial use without attribution)

The content was modified in the following languages:

  • English
  • German
  • French

@netlify
Copy link

netlify bot commented Jul 14, 2025 •
edited
Loading

✅ Deploy Preview for fipguide ready!

Name Link
🔨 Latest commit 66b2102
🔍 Latest deploy log https://app.netlify.com/projects/fipguide/deploys/687e987f480c530008e6636d
😎 Deploy Preview https://deploy-preview-239--fipguide.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@MoritzWeber0 MoritzWeber0 changed the title Add French feat: Add French language Jul 14, 2025
@MoritzWeber0 MoritzWeber0 added content Improvements or additions to the content (countries, news, operators, general content) technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc. labels Jul 14, 2025
@MoritzWeber0
Copy link
Member

MoritzWeber0 commented Jul 14, 2025 •
edited
Loading

Hi @antvgr! Thanks for the effort to support the FIP Guide and making it available to a larger crowd by adding the French language ❤️

I ran the pre-commit hooks (these are Git hooks to apply some basic formatting locally) and it removed all trailing whitespaces. We decided to use backslashes (\) instead of two trailing whitespaces since trailing whitespaces are hard to recognize in text editors. I can recommend to set up pre-commit on your local device, instructions are available in our CONTRIBUTING.md.

Currently, the news overview on the main page is broken too - I'll have a look at it in the next few days.

@MoritzWeber0
Copy link
Member

MoritzWeber0 commented Jul 15, 2025

I tried to fix all formatting issues, but it's probably worth checking all pages again.

Main open topics until it can be merged:

  • Translations for news articles is missing (files in content/news)
  • Some pages don't use expanders for train categories. We should ensure consistency here.

lenderom
lenderom reviewed Jul 15, 2025
View reviewed changes
Copy link
Member

@lenderom lenderom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will continue my review later

@lenderom lenderom mentioned this pull request Jul 15, 2025
Open
@lenderom
Copy link
Member

lenderom commented Jul 15, 2025

From my side I'm finished with the review

MoritzWeber0
MoritzWeber0 reviewed Jul 19, 2025
View reviewed changes
MoritzWeber0 and others added 3 commits July 21, 2025 14:19
@lenderom lenderom merged commit 6162d2a into fipguide:main Jul 21, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MoritzWeber0 MoritzWeber0 MoritzWeber0 left review comments

@lenderom lenderom lenderom left review comments

Assignees

No one assigned

Labels

content Improvements or additions to the content (countries, news, operators, general content) technical Technical issues, e.g. related to Hugo, HTML, CSS, deployment, etc.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@antvgr @MoritzWeber0 @lenderom