feat: Present booking methods as custom expanders #180
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoritzWeber0
changed the title
lenderom
force-pushed
the
feat/booking-shortcode
branch
from
76ce518 to
3471c07
Compare
MoritzWeber0
force-pushed
the
feat/booking-shortcode
branch
2 times, most recently
from
fac9308 to
01300dd
Compare
MoritzWeber0
commented
Jun 8, 2025
MoritzWeber0
force-pushed
the
refactor/define-divider
branch
from
1a9e676 to
7152468
Compare
Signed-off-by: lennartrommeiss <[email protected]>
Signed-off-by: lennartrommeiss <[email protected]>
Signed-off-by: lennartrommeiss <[email protected]>
MoritzWeber0
force-pushed
the
feat/booking-shortcode
branch
from
a3e24fb to
5a52f44
Compare
MoritzWeber0
force-pushed
the
refactor/define-divider
branch
from
0977d3a to
9974e85
Compare
## Description By default, Hugo only allows using `http:`, `https:`, and `mailto:`. URLs using other schemes are replaced with `#ZgotmplZ`. To allow using `tel:`, we have to declare it as safe using `| safeURL`. This marks every URL as safe which should be fine, since all content inside the repo is trusted. See https://gohugo.io/functions/safe/url/ for more info. Closes #185 <!-- Add a short description here / Eine kurze Beschreibung hier einfügen --> ## Checklist <!-- Check fields with: [x] / Abhaken von Punkten: [x] --> - [x] Check the License of new pictures (non-commercial use without attribution) <!-- Die Lizenz neuer Bilder geprüft (nicht-kommerzielle Nutzung ohne Namensnennung) --> The content was modified in the following languages: <!-- Der Inhalt wurde für die folgenden Sprachen angepasst --> - [ ] English - [ ] German --------- Co-authored-by: Moritz Weber <[email protected]>
Signed-off-by: lennartrommeiss <[email protected]>
Member
Author
|
Deploy preview: https://deploy-preview-180--fipguide.netlify.app/en/ |
therobrob
reviewed
Jun 14, 2025
Member
therobrob
left a comment
therobrob
left a comment
There was a problem hiding this comment.
With the display of booking methods as an expander, we have a great new feature for the website, thank you for that! I have a few comments. Let's talk if something is unclear or you see things differently. :)
Signed-off-by: lennartrommeiss <[email protected]>
lenderom
force-pushed
the
feat/booking-shortcode
branch
from
a87515c to
2b6a1c7
Compare
The ::before pseudo-element wasn't included in the flexbox and the margins / gap wasn't applied properly
Use the hex variables as single source of truth. Maintaining another set in rgb colors is error-prone and SCSS can transfer it on demand.
MoritzWeber0
commented
Jun 16, 2025
Signed-off-by: lennartrommeiss <[email protected]>
This was referenced Jun 19, 2025
therobrob
approved these changes
Jun 19, 2025
MoritzWeber0
added
the
technical
This was referenced Jun 21, 2025
therobrob
added a commit
that referenced
this pull request
Jun 22, 2025
As correctly mentioned by @therobrob in #180 (comment), `.o-list` is already used for the overview pages and we should change the name of `.o-list--columns`. Since it's actually not just usable by lists itself and can be used to split all different kinds of sections into columns, `.o-section--columns` is a good replacement in my eyes. Co-authored-by: Robert Schuster <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move booking information to own pages. Embed the pages via custom expanders to the operator pages.